-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mosquitto: fix pkg-config files #273652
mosquitto: fix pkg-config files #273652
Conversation
Result of 7 packages built:
|
Result of 2 packages marked as broken and skipped:
3 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3087 |
|
||
postFixup = '' | ||
echo "Fixing pkg-config files" | ||
sed -i "s|^prefix=.*|prefix=$lib|g" $dev/lib/pkgconfig/*.pc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be super awesome if we could fix the cmake file that generates this and upstream it.
- Fix prefix in pkg-config files - Use uthash from nixpkgs instead of bundled one (preffered way) - No need make -C man, manpages are generated by default - No need -DWITH_THREADING=ON, it's ON by default
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1316 |
Result of 7 packages built:
nixos test also passes, LGTM. Thanks! |
Description of changes
Before:
After:
uthash
from nixpkgs instead of bundled onemake -C man
, manpages are generated by default-DWITH_THREADING=ON
, it's ON by defaultThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.