Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.fly-pie: reenable #274080

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

jackwilsdon
Copy link
Contributor

Description of changes

gnomeExtensions.fly-pie was disabled due to #118612 as it contained unicode filenames. #118612 has since been fixed by #176253, meaning we can re-enable the extension.

It also turns out that Fly-Pie renamed the offending files a while back anyway: Schneegans/Fly-Pie@66e4331

Fixes #273655.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 13, 2023
@D3vil0p3r
Copy link
Contributor

LGTM

@NickCao NickCao merged commit 164ba05 into NixOS:master Dec 14, 2023
25 of 26 checks passed
@jackwilsdon jackwilsdon deleted the reenable-fly-pie branch December 14, 2023 14:48
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: gnomeExtensions.flypie
3 participants