Fixes for various bugs introduced by stdenv update in staging #27522

ttuegel · 2017-07-20T14:40:00Z

Motivation

staging is broken.

Testing

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

The bugfixes in this branch work, but I am not done testing to check that these are all the blocking bugs in staging.

Previously failed on installation phase when `substituteInPlace` could not find the cmake exports file.

Simple tool for creating Ethereum-based dapps

Fixes NixOS#21345 by generating the icon cache when the theme is installed.

keybase: 1.0.20 -> 1.0.22 keybase-gui: 1.0.23-20170519175207.d6c5e9e -> 1.0.25-20170714172717.73f9070 kbfs: 20170209.d1db463 -> 20170429.44efa06

calibre: fix html5lib error

I'm also removing the pants13-pre attribute since it's unnecessary and I don't want to maintain 1.4.x prereleases yet. I'm temporarily taking out the pants native rust engine shenanigans until I can get a nix-native rust build of it to work (it works on Linux but not on Darwin!)

Corebird requires gtksink gstreamer plugin to play videos. [1] The plugin, however, is only built when GTK is available. This patch adds gtk3 as an optional dependency to gst_all_1.gst-plugins-bad package, allowing the build of gtksink. [1]: baedert/corebird#431

Corebird requires gst-plugins-bad compiled with GTK support to play videos. This commit enables the GTK support.

gst_all_1.gst-plugins-bad: build gtksink plugin

dapp: init at v0.5.2

Sorry, I broke evaluation in my last pants commit!

Otherwise some programmes cannot use the GPG agent, e.g. applications started from dmenu. Behaviour was changed in NixOS#26888, this reverts that part.

bitlbee service: Add option to load libpurple plugins into bitlbee

Google PageSpeed recommends turning this on to allow proxies to cache

The systemd service file shipped with strongswan has strongswan started after `network-online`. It turns out that this is for good reason: failure to connect on boot otherwise. See this thread on the mailing list, which my colleague initiated after finding that our NixOS strongswan config wouldn't connect on boot: https://lists.strongswan.org/pipermail/users/2017-January/010359.html Tested on a local config (which has the strongswan service config overridden).

Semi-automated Emacs package updates

Parallel building causes a test deadlock and has been disabled.

Commit 093cc00 sets the RANLIB environment variable by default, causing `make' to invoke the wrong program.

Commit 093cc00 sets the environment variable `AS' to the binutils assembler, but x264 needs yasm.

substituteInPlace was invoked with multiple targets on the command line, which is not supported.

Commit 093cc00 sets the environment variable `CPP' by default, but this intereferes with dependency calculation.

Commit 093cc00 sets the environment variable `CPP' by default, but this interferes with dependency calculation.

Commit 093cc00 sets the `LD' environment variable by default, interfering with the Makefile which uses gcc for linking.

substituteInPlace was invoked with multiple targets on the command line, which is not supported.

joachifm · 2017-07-22T15:21:38Z

In the short term, can @Ericson2314 and others who wish to work on fundamental features be allotted a jobset(s) on hydra, so that staging can return to serve its original purpose? I know there are some such jobsets already but it's not at all transparent how they are allocated.

knedlsepp · 2017-07-22T15:51:51Z

pkgs/development/libraries/libunistring/default.nix

@@ -14,6 +14,8 @@ stdenv.mkDerivation rec {

  propagatedBuildInputs = stdenv.lib.optional (!stdenv.isLinux) libiconv;

+  enableParallelBuilding = false;


I've been having trouble building libunistring on openSUSE using nix, which I only solved by using an overlay that disabled tests for that particular library. It always got stuck in the test-lock test with full CPU usage. Does this solve that particular issue? I think I had the same problem with findutils. Let me see if I can recreate the issue on that particular machine.

Commit 093cc00 sets the AR environment variable by default, but this causes the jam Makefile to use the wrong command.

Commit 093cc00 sets the AR environment variable by default, but this causes the argyllcms Makefile to use the wrong command.

ttuegel · 2017-07-23T02:19:52Z

At this stage, all the NixOS tests are passing which were not already broken before the stdenv update, so I am going to merge this.

ttuegel · 2017-07-23T12:11:13Z

@edolstra Hydra hasn't evaluated the staging branch. Could you nudge it in the right direction?

FRidh · 2017-07-23T12:30:47Z

@ttuegel http://hydra.nixos.org/eval/1377845 includes these changes

Ericson2314 · 2017-07-23T17:12:53Z

@joachifm I tried to use http://hydra.nixos.org/jobset/nixpkgs/ericson2314-cross-staging, but it never would evaluate. :/

Ericson2314 · 2017-07-23T17:15:02Z

@ttuegel Wow. Thank you so much! I really owe you for cleaning up my mess---collect that debt someday.

domenkozar · 2017-07-24T13:10:24Z

@ttuegel thank you man :)

domenkozar · 2017-07-24T13:15:17Z

Go seems to be still broken: /nix/store/xilxav9i6xkrra3vclmlm7zwbbvr46qv-go-1.8.3/share/go/pkg/tool/linux_amd64/link: too many errors at http://hydra.nixos.org/build/56796101

@Ericson2314 any clues?

FRidh · 2017-07-24T13:22:04Z

@domenkozar @Ericson2314 issue for Go #27589

copumpkin · 2017-07-25T13:55:14Z

I second giving @Ericson2314 his own Hydra job for testing his cross-compilation changes. When I was making sweeping changes to the Darwin stdenv (which is if anything less impactful to everyone than the work he's doing), I used the copumpkin-wip job on Hydra and it was extremely helpful for finding things I would've never found otherwise. Combined with "incrementalism" in my changes, that allowed me to make some pretty sweeping changes to a lot of the Darwin fundamentals a few months ago, without anyone really noticing (at least not negatively).

globin · 2017-07-25T20:03:33Z

@edolstra @rbvermaa ^

Ericson2314 · 2017-07-25T21:21:31Z

I have hydra perms to make jobs, and @grahamc realized the problem was simply that I had previous disabled my job 😊. We're all good.

aherrmann and others added 30 commits June 6, 2017 21:39

llvm_4: Fix debugVersion

1cfed62

Previously failed on installation phase when `substituteInPlace` could not find the cmake exports file.

calibre: fix html5lib error

56743ea

dapp: init at v0.5.2

8d9740e

Simple tool for creating Ethereum-based dapps

journalwatch & journalwatch service: init at 1.1.0

63bb133

breeze-icons: generate icon cache

0d06192

Fixes NixOS#21345 by generating the icon cache when the theme is installed.

bitlbee: Add optional libpurple dependency

ce6fe1a

bitlbee service: Add option to load libpurple plugins into bitlbee

65e38b7

Keybase updates

f74a1e6

keybase: 1.0.20 -> 1.0.22 keybase-gui: 1.0.23-20170519175207.d6c5e9e -> 1.0.25-20170714172717.73f9070 kbfs: 20170209.d1db463 -> 20170429.44efa06

solvespace: Fix path in desktop entry file

ff22d73

python.pkgs.pytorch: init at 0.1.12

567b84d

Merge pull request NixOS#27290 from calvertvl/fix_calibre_html5lib

42cdad0

calibre: fix html5lib error

imagemagick: 6.9.8-10 -> 6.9.9-0

0e9676f

imagemagick7: 7.0.6-0 -> 7.0.6-1

cff27d5

corebird: fix video playback

e564f16

Corebird requires gst-plugins-bad compiled with GTK support to play videos. This commit enables the GTK support.

coqPackages.compcert: Recent compcert supports 64-bit architectures

f130ecd

Merge pull request NixOS#27005 from jtojnar/fix/corebird-gst

28b7d01

gst_all_1.gst-plugins-bad: build gtksink plugin

Merge pull request NixOS#27445 from dapphub/dapp

24a3188

dapp: init at v0.5.2

elpa-packages: 2017-07-17

960978f

org-packages: 2017-07-17

5a48826

melpa-stable-packages: 2017-07-17

b8213ab

melpa-packages: 2017-07-17

58b269f

pants13-pre: remove from pythonPackages

b4ee24d

Sorry, I broke evaluation in my last pants commit!

programs.gnupg: use extraInit instead of interactiveShellInit

b8d92a7

Otherwise some programmes cannot use the GPG agent, e.g. applications started from dmenu. Behaviour was changed in NixOS#26888, this reverts that part.

Merge pull request NixOS#27057 from Nadrieril/bitlbee-libpurple

04c944c

bitlbee service: Add option to load libpurple plugins into bitlbee

nginx: add gzip_vary to recommended settings

c4783a9

Google PageSpeed recommends turning this on to allow proxies to cache

html-xml-utils: 6.9 → 7.1, macOS support

90f0c3b

Merge pull request NixOS#27450 from mdorman/emacs-updates

ea81107

Semi-automated Emacs package updates

ttuegel added 5 commits July 21, 2017 15:46

systemd: fix broken source hash

aa11af8

libunistring: disable parallel building

1577646

Parallel building causes a test deadlock and has been disabled.

systemd: unset RANLIB

631f6b3

Commit 093cc00 sets the RANLIB environment variable by default, causing `make' to invoke the wrong program.

x264: unset AS

20321f6

Commit 093cc00 sets the environment variable `AS' to the binutils assembler, but x264 needs yasm.

zfs: fix invalid use of substituteInPlace

b21defa

substituteInPlace was invoked with multiple targets on the command line, which is not supported.

ttuegel force-pushed the bugfix/staging/stdenv branch from da8926a to b7f1895 Compare July 21, 2017 20:48

ttuegel added 4 commits July 21, 2017 16:49

grub2: unset CPP

5265d55

Commit 093cc00 sets the environment variable `CPP' by default, but this intereferes with dependency calculation.

qemu: unset CPP

fe80044

Commit 093cc00 sets the environment variable `CPP' by default, but this interferes with dependency calculation.

qt4: unset LD

9aa4f09

Commit 093cc00 sets the `LD' environment variable by default, interfering with the Makefile which uses gcc for linking.

syslinux: fix invalid use of substituteInPlace

bec5797

substituteInPlace was invoked with multiple targets on the command line, which is not supported.

ttuegel force-pushed the bugfix/staging/stdenv branch from b7f1895 to bec5797 Compare July 21, 2017 21:52

Merge branch 'master' into bugfix/staging/stdenv

6a004bf

knedlsepp reviewed Jul 22, 2017

View reviewed changes

FRidh mentioned this pull request Jul 22, 2017

PULL_REQUEST_TEMPLATE: Ask for docs #27331

Merged

ttuegel added 3 commits July 22, 2017 17:43

nixos/tests/keymap: use SLIM theme from nixos/tests/slim

4b14212

jam: unset AR

4f88cef

Commit 093cc00 sets the AR environment variable by default, but this causes the jam Makefile to use the wrong command.

argyllcms: unset AR

101e099

Commit 093cc00 sets the AR environment variable by default, but this causes the argyllcms Makefile to use the wrong command.

ttuegel merged commit 9af7782 into NixOS:staging Jul 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for various bugs introduced by stdenv update in staging #27522

Fixes for various bugs introduced by stdenv update in staging #27522

ttuegel commented Jul 20, 2017 •

edited

joachifm commented Jul 22, 2017

knedlsepp Jul 22, 2017

ttuegel commented Jul 23, 2017

ttuegel commented Jul 23, 2017

FRidh commented Jul 23, 2017

Ericson2314 commented Jul 23, 2017

Ericson2314 commented Jul 23, 2017

domenkozar commented Jul 24, 2017

domenkozar commented Jul 24, 2017

FRidh commented Jul 24, 2017

copumpkin commented Jul 25, 2017 •

edited

globin commented Jul 25, 2017

Ericson2314 commented Jul 25, 2017

		@@ -14,6 +14,8 @@ stdenv.mkDerivation rec {

		propagatedBuildInputs = stdenv.lib.optional (!stdenv.isLinux) libiconv;

		enableParallelBuilding = false;

Fixes for various bugs introduced by stdenv update in staging #27522

Fixes for various bugs introduced by stdenv update in staging #27522

Conversation

ttuegel commented Jul 20, 2017 • edited

Motivation

Testing

joachifm commented Jul 22, 2017

knedlsepp Jul 22, 2017

Choose a reason for hiding this comment

ttuegel commented Jul 23, 2017

ttuegel commented Jul 23, 2017

FRidh commented Jul 23, 2017

Ericson2314 commented Jul 23, 2017

Ericson2314 commented Jul 23, 2017

domenkozar commented Jul 24, 2017

domenkozar commented Jul 24, 2017

FRidh commented Jul 24, 2017

copumpkin commented Jul 25, 2017 • edited

globin commented Jul 25, 2017

Ericson2314 commented Jul 25, 2017

ttuegel commented Jul 20, 2017 •

edited

copumpkin commented Jul 25, 2017 •

edited