Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/paperless: convert extraConfig to freeform type #277019

Merged
merged 1 commit into from Jan 4, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 27, 2023

Description of changes

Tested on installation including with the types in the example.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed, thanks.

A couple notes and improvements.

Tested to be working :)

nixos/modules/services/misc/paperless.nix Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/paperless.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 changed the title nixos/paperless: convert extraConfig to freeform nixos/paperless: convert extraConfig to freeform type Dec 29, 2023
@SuperSandro2000 SuperSandro2000 force-pushed the paperless-freeform branch 3 times, most recently from 9e87946 to 5d9f8a9 Compare December 29, 2023 21:42
@mweinelt
Copy link
Member

Please make sure to loop in the maintainers, when you're only changing the module, as they don't get requested by ofBorg in that case.

Co-authored-by: Atemu <atemu.main@gmail.com>
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Atemu Atemu merged commit 94e446c into NixOS:master Jan 4, 2024
20 checks passed
@SuperSandro2000 SuperSandro2000 deleted the paperless-freeform branch January 6, 2024 16:21
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request Jan 9, 2024
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in NixOS#277019.
yayayayaka added a commit that referenced this pull request Jan 9, 2024
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in #277019.
slam-bert pushed a commit to slam-bert/nixpkgs that referenced this pull request Jan 11, 2024
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in NixOS#277019.
github-actions bot pushed a commit to Mic92/nixpkgs that referenced this pull request Jan 14, 2024
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in NixOS#277019.
flandweber pushed a commit to flandweber/nixpkgs that referenced this pull request Jan 21, 2024
`services.paperless.extraConfig` has been replaced with
`services.paperless.settings` in NixOS#277019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants