-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bookletimposer: remove + maintainer email address update #278100
bookletimposer: remove + maintainer email address update #278100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the package to pkgs/top-level/aliases.nix
. Look for examples with throw
.
BookletImposer is now broken, both on unstable and 23.11, and seems unmaintained. The package stopped working with PyPDF 3.0, which NixOS now uses. The forge is now down, and I tried contacting the author by mail without answer as of today. I think removing this package from unstable and 23.11 makes sense.
d8a824e
to
6f8527f
Compare
Thanks, updated |
This sounds like you're saying that you're the NixOS maintainer of bookletimposer but you're not in the list of maintainers: maintainers = with lib.maintainers; [ afontain ]; and you've never changed the That question aside, I think removing this package is reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the git hoster shut down at the end of March 2023 and the maintainer of the package hasn't picked a new one yet, I think it's reasonable to assume that this project is dead.
See https://web.archive.org/web/20230623172617/https://git.codecoop.org/ and https://so36.net/news/codecoop-migration.html.
For the maintainer thing, the name -> github name correspondance can be seen in /maintainers/maintainer-list.nix. It's a bit confusing I'll admit. This also made me notice that this email address was outdated, I've added a commit to fix that if that's ok for you. |
39eb14f
to
97840da
Compare
We don't normally backport removals, but since this package is broken at runtime already in 23.11 this case is an exception. |
Successfully created backport PR for |
Description of changes
As the NixOS package maintainer, I recommend deleting the BookletImposer package. This PR deletes BookletImposer, as it is now broken both on unstable and 23.11, and seems unmaintained.
The package stopped working with PyPDF 3.0, which NixOS now uses. The forge is now down, and I tried contacting the author by mail without answer as of today. I think removing this package from unstable and 23.11 makes sense.
Things done
Questions