Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bookletimposer: remove + maintainer email address update #278100

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

necessarily-equal
Copy link
Contributor

@necessarily-equal necessarily-equal commented Jan 1, 2024

Description of changes

As the NixOS package maintainer, I recommend deleting the BookletImposer package. This PR deletes BookletImposer, as it is now broken both on unstable and 23.11, and seems unmaintained.

The package stopped working with PyPDF 3.0, which NixOS now uses. The forge is now down, and I tried contacting the author by mail without answer as of today. I think removing this package from unstable and 23.11 makes sense.

Things done

Questions

  1. Should I delete the package in stable as well? In that case, can somebody add the "stable-backport" label to this PR? (I assume this would cherry-pick cleanly)
  2. Under which section should I add an entry in the release notes? I don't see a "breaking change" or "package removal" section here: https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md
  3. If we backport this to stable, should this also be added to the 23.11 release notes?

Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add the package to pkgs/top-level/aliases.nix. Look for examples with throw.

BookletImposer is now broken, both on unstable and 23.11, and seems
unmaintained.

The package stopped working with PyPDF 3.0, which NixOS now uses. The
forge is now down, and I tried contacting the author by mail without
answer as of today. I think removing this package from unstable and
23.11 makes sense.
@necessarily-equal
Copy link
Contributor Author

Thanks, updated

@Luflosi
Copy link
Contributor

Luflosi commented Jan 1, 2024

Cc @afontain and @Artturin

@Luflosi
Copy link
Contributor

Luflosi commented Jan 2, 2024

As the NixOS package maintainer, I recommend deleting the BookletImposer package

This sounds like you're saying that you're the NixOS maintainer of bookletimposer but you're not in the list of maintainers:

maintainers = with lib.maintainers; [ afontain ];

and you've never changed the pkgs/applications/office/bookletimposer/default.nix file before so what do you mean by what you said?

That question aside, I think removing this package is reasonable.

Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the git hoster shut down at the end of March 2023 and the maintainer of the package hasn't picked a new one yet, I think it's reasonable to assume that this project is dead.
See https://web.archive.org/web/20230623172617/https://git.codecoop.org/ and https://so36.net/news/codecoop-migration.html.

@necessarily-equal necessarily-equal changed the title bookletimposer: remove bookletimposer: remove + maintainer email address update Jan 2, 2024
@necessarily-equal
Copy link
Contributor Author

For the maintainer thing, the name -> github name correspondance can be seen in /maintainers/maintainer-list.nix. It's a bit confusing I'll admit.

This also made me notice that this email address was outdated, I've added a commit to fix that if that's ok for you.

@adisbladis
Copy link
Member

adisbladis commented Jan 2, 2024

We don't normally backport removals, but since this package is broken at runtime already in 23.11 this case is an exception.

@adisbladis adisbladis merged commit 8a5323a into NixOS:master Jan 2, 2024
19 checks passed
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants