haskell infra: Misc cleanups #27840
Closed
haskell infra: Misc cleanups #27840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
haskell-explicit-stdenv
branch
from
7ecde0f
to
80c424d
Compare
domenkozar
approved these changes
Aug 1, 2017
peti
requested changes
Aug 1, 2017
There was a problem hiding this comment.
With that patch applied, I get errors trying to evaluate Nixpkgs:
❯ nix-env -qaP --show-trace
error: while evaluating the attribute ‘haskellPackages.callPackage’ at /home/simons/.config/nixpkgs/config.nix:168:5:
while evaluating the attribute ‘haskellPackages.override’ at /home/simons/.nix-defexpr/pkgs/top-level/all-packages.nix:5548:3:
while evaluating the attribute ‘packages.ghc802.override’ at /home/simons/.nix-defexpr/pkgs/top-level/haskell-packages.nix:162:5:
while evaluating ‘callPackageWith’ at /home/simons/.nix-defexpr/lib/customisation.nix:113:35, called from /home/simons/.nix-defexpr/pkgs/top-level/haskell-packages.nix:162:14:
while evaluating ‘makeOverridable’ at /home/simons/.nix-defexpr/lib/customisation.nix:72:24, called from /home/simons/.nix-defexpr/lib/customisation.nix:117:8:
undefined variable ‘callPackage’ at /home/simons/.nix-defexpr/pkgs/development/haskell-modules/default.nix:15:21
Did you actually test this patch?
|
@peti I evaluated one derivation, but meant to mark it WIP pending more testing. Odd my one derivation did not pick that up... |
Ericson2314
force-pushed
the
haskell-explicit-stdenv
branch
from
80c424d
to
443aa41
Compare
- The haskell lib is very close to not relying on Nixpkgs. I think this is good---simpler to think about and matches Nixpkgs's lib. - The haskell lib is only imported once - stdenv is exposed more shallowly so it can be overriden more easily. I'll eventually use this on Darwin to avoid the Sierra shared library problems (unless changes are to be made system-wide).
Ericson2314
force-pushed
the
haskell-explicit-stdenv
branch
from
443aa41
to
542d68f
Compare
|
Ok, |
|
Pulled to |
peti
approved these changes
Aug 2, 2017
|
@peti err to be clear this shouldn't change any hashes. Can I force eval of your job to expedite merging then? |
Ericson2314
added a commit
that referenced
this pull request
Aug 3, 2017
- The haskell lib is very close to not relying on Nixpkgs. I think this is good---simpler to think about and matches Nixpkgs's lib. - The haskell lib is only imported once - stdenv is exposed more shallowly so it can be overriden more easily. I'll eventually use this on Darwin to avoid the Sierra shared library problems (unless changes are to be made system-wide). Closes #27840.
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
- The haskell lib is very close to not relying on Nixpkgs. I think this is good---simpler to think about and matches Nixpkgs's lib. - The haskell lib is only imported once - stdenv is exposed more shallowly so it can be overriden more easily. I'll eventually use this on Darwin to avoid the Sierra shared library problems (unless changes are to be made system-wide). Closes NixOS#27840.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The haskell lib is very close to not relying on Nixpkgs. I think this is good---simpler to think about and matches Nixpkgs's lib.
stdenv is exposed more shallowly so it can be overriden more easily. I'll eventually use this on Darwin to avoid the Sierra shared library problems (unless changes are to be made system-wide).
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)