nixos/repart: add loop module to initrd #278895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemd-repart will use loopback devices for partition creation if it is able to, and will fallback to doing "offline" partition creation writing data directly to files. From what I see looking at the repart code, there are specific features that cannot be taken advantage of when not using loopback devices (e.g. no BTRFS subvolumes in systemd v255) and in certain places they have to perform some manual re-sizing work that can otherwise be avoided.
arianvp
approved these changes
Jan 5, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Systemd-repart will use loopback devices for partition creation if it is able to, and will fallback to doing "offline" partition creation writing data directly to files. From what I see looking at the repart code, there are specific features that cannot be taken advantage of when not using loopback devices (e.g. no BTRFS subvolumes in systemd v255) and in certain places they have to perform some manual re-sizing work that can otherwise be avoided.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.