python3Packages.pure-protobuf: 3.0.0 -> 2.3.0 #280551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 3 packages built:
|
kirillrdy
reviewed
Jan 13, 2024
chuangzhu
force-pushed
the
pure-protobuf-rollback
branch
from
8a38986
to
90ec4a5
Compare
|
@GrahamcOfBorg build pure-protobuf |
|
@chuangzhu please update commit message and PR title to python3Packages.pure-protobuf ( or alternatives ) |
chuangzhu
force-pushed
the
pure-protobuf-rollback
branch
from
90ec4a5
to
18bb8a0
Compare
chuangzhu
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1384 |
|
@GrahamcOfBorg build python3Packages.pure-protobuf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rollback pure-protobuf. Context: #280506
I tried to fix the 3.0.0 version in 0fbbc44, but soon I confirmed that the only package in Nixpkgs that uses pure-protobuf doesn't launch with 3.0.0.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.