Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: fix build by relaxing aiostream #280935

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

antonmosich
Copy link
Contributor

Description of changes

vdirsyncer depends on aiostream<5.0, but aiostream 5 didn't introduce any changes which break vdirsyncer as far as I know thus relaxing the dependency fixes the build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • [] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

vdirsyncer depends on aiostream<5.0, but aiostream 5 didn't introduce
any changes which break vdirsyncer as far as I know thus relaxing the
dependency fixes the build
@Mic92 Mic92 merged commit 06751d4 into NixOS:master Jan 14, 2024
4 of 5 checks passed
@DamienCassou
Copy link
Contributor

Upstream issue: pimutils/vdirsyncer#1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants