Kdepim 17.08 #28418
Kdepim 17.08 #28418
Conversation
|
@vandenoever, thanks for your PR! By analyzing the history of the files in this pull request, we identified @adisbladis, @ttuegel and @phunehehe to be potential reviewers. |
vandenoever
force-pushed
the
kdepim-17.08
branch
from
51d76fc
to
b37eafd
Compare
|
KMail 17.08 works fine in this branch. I think I tried all PIM applications (akregator, kaddressbook, kontact, kleopatra). Hope this can finally land. |
vandenoever
force-pushed
the
kdepim-17.08
branch
from
b37eafd
to
a8d7561
Compare
vandenoever
force-pushed
the
kdepim-17.08
branch
from
a8d7561
to
cea59ff
Compare
|
@ttuegel These are some more patches needed to get kdepim to work on kdeapplications 17.08. |
| @@ -44,17 +44,6 @@ Index: grantleetheme-17.04.0/src/grantleetheme.cpp | |||
| loader->setTheme(dirName); | |||
|
|
|||
| if (!sEngine) { | |||
| @@ -102,9 +105,7 @@ QString ThemePrivate::errorTemplate(cons | |||
There was a problem hiding this comment.
The purpose of this part is unclear to me. The patch as it was was reverting an improvement, namely the check for a null pointer.
| @@ -1,2 +1 @@ | |||
| grantleetheme_check_null.patch | |||
There was a problem hiding this comment.
it was applied upstream
29770046
| @@ -15,7 +15,7 @@ mkDerivation { | |||
| maintainers = with maintainers; [ sander phreedom ]; | |||
| platforms = platforms.linux; | |||
| }; | |||
| nativeBuildInputs = [ extra-cmake-modules kdoctools makeWrapper shared_mime_info ]; | |||
There was a problem hiding this comment.
Why is shared_mime_info removed from nativeBuildInputs but retained in the arguments to the package (above)?
There was a problem hiding this comment.
it's still present in propagatedBuildInputs
| @@ -1,2 +1 @@ | |||
| grantleetheme_check_null.patch | |||
There was a problem hiding this comment.
it was applied upstream
29770046
| @@ -15,7 +15,7 @@ mkDerivation { | |||
| maintainers = with maintainers; [ sander phreedom ]; | |||
| platforms = platforms.linux; | |||
| }; | |||
| nativeBuildInputs = [ extra-cmake-modules kdoctools makeWrapper shared_mime_info ]; | |||
There was a problem hiding this comment.
it's still present in propagatedBuildInputs
| @@ -44,17 +44,6 @@ Index: grantleetheme-17.04.0/src/grantleetheme.cpp | |||
| loader->setTheme(dirName); | |||
|
|
|||
| if (!sEngine) { | |||
| @@ -102,9 +105,7 @@ QString ThemePrivate::errorTemplate(cons | |||
There was a problem hiding this comment.
The purpose of this part is unclear to me. The patch as it was was reverting an improvement, namely the check for a null pointer.
Motivation for this change
Compile fixes for the KDEPIM packages.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)