-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5: Add qtnetworkauth submodule #28480
Conversation
qtSubmodule { | ||
name = "qtnetworkauth"; | ||
qtInputs = [ qtbase ]; | ||
outputs = [ "out" "dev" "bin" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilpianista As is, the build does not produce any QML outputs. If that is correct, please remove the bin
output and the postInstall
hook below. If the build should produce QML outputs, add qtdeclarative
to the qtInputs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttuegel It doesn't produce any QML output. Fixed, thanks!
|
@ttuegel it seems merging this has broken the eval |
Reverted now. |
Indeed, fe0ab94 refactored all qt5 packages and then this is broken now. Unfortunately I'm not using NixOS anymore at the moment, so I'll not update this PR. Thanks anyway! |
Sorry, I foolishly assumed that Git would report a merge conflict if there was a problem with the refactoring. Somehow I always seem to find trivial conflicts need to be manually resolved, while Git "automatically" resolves non-trivial conflicts badly. |
Motivation for this change
Add QtNetworkAuth module available since Qt 5.8.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)