libcamera-qcam: init #284964
Merged
libcamera-qcam: init #284964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K900
approved these changes
Jan 30, 2024
Quoting the patch:
I'd rather not introduce another qt5 dependency into nixpkgs ;-) |
|
That's not really the case, the KDE people maintain a Qt5 patchset that we track, and it'll be around for a while. I don't really see any issues with Qt5 stuff yet. |
flokli
added a commit
to flokli/nixpkgs
that referenced
this pull request
Jan 30, 2024
libcamera provides a more helpful debugging gui, which however needs qt, so is undesirable in the default case (which is why it was disabled initially). Introduce a withQcam boolean flag, which will enable building it with qcam, and expose it as a toplevel libcamera-qcam attribute. This helped debugging the new ipu6 softisp camera stack. The Qt 6 support patch is already circulating on the upstream mailing list, however it doesn't apply cleanly. As discussed in NixOS#284964, we opted to not ship that patch, but rather use qt5 for now, as KDE seems to maintain a Qt5 patchset that we track.
flokli
force-pushed
the
libcamera-qcam
branch
from
647adc8
to
7190be6
Compare
|
Alright, I updated this PR and removed the qt6 patch from the history, PTAL. I left a pointer in the commit message, in case someone is wondering, even though I'd hope by then upstream switched to qt6 too. |
libcamera provides a more helpful debugging gui, which however needs qt, so is undesirable in the default case (which is why it was disabled initially). Introduce a withQcam boolean flag, which will enable building it with qcam, and expose it as a toplevel libcamera-qcam attribute. This helped debugging the new ipu6 softisp camera stack. The Qt 6 support patch is already circulating on the upstream mailing list, however it doesn't apply cleanly. As discussed in NixOS#284964, we opted to not ship that patch, but rather use qt5 for now, as KDE seems to maintain a Qt5 patchset that we track.
The CI check complains about a new attribute introduced that's not using the by-name pattern, even though it's using the same .nix file. It seems using callPackage ../by-name/… from toplevel for the alternative toplevel attribute seems to be others do this, so using the same pattern here.
flokli
force-pushed
the
libcamera-qcam
branch
from
7190be6
to
d6ee968
Compare
infinisil
reviewed
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcamera provides a more helpful debugging gui, which however needs qt, so is undesirable in the default case (which is why it was disabled initially).
Introduce a withQcam boolean flag, which will enable building it with qcam, and expose it as a toplevel libcamera-qcam attribute.
This helped debugging the new ipu6 softisp camera stack.
The Qt 6 support patch is already circulating on the upstream mailing list, however it doesn't apply cleanly.
Use the version from
https://copr-dist-git.fedorainfracloud.org/cgit/jwrdegoede/ipu6-softisp/libcamera.git/tree/0001-apps-qcam-Port-to-Qt-6.patch?h=f39 which has been rebased to apply.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.