obsidian: fix wayland support

[tschai-yim]

Description of changes

This PR improves the usability of the obsidian package in Wayland with following things:

• Add libglvnd as dependency to resolve chromium/electron/element-desktop on wayland fails to find libEGL.so #268490
• Add the commandLineArgs parameter for use in overlays
  • I personally use it to add --disable-features=WaylandFractionalScaleV1 like in Chrome and VSCode
  • Remove in favor of manually wrapping the package:

pkgs.symlinkJoin {
 name = "obsidian";
 paths = [ pkgs.obsidian ];
 buildInputs = [ pkgs.makeWrapper ];
 postBuild = ''
   wrapProgram $out/bin/obsidian \
     --add-flags "--disable-features=WaylandFractionalScaleV1"
 '';
}

Things done

The changes work on my personal NixOS GNOME system.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[DontEatOreo]

Please rebase and follow NixOS Commit conventions instead of Conventional Commits

[zaninime]

I believe one commit with both changes would be enough, however I don't mind the two.

[h7x4]

I believe one commit with both changes would be enough

I think two commits are more correct. Since the changes are unrelated, it fits better with the one commit per logical unit convention.

[alexandru0-dev]

when this is going to be merged? as it seems to not lacking anything and already approved

[Suyashtnt]

I tried to use this (by copy pasting the modified file into my packages directory and then importing the custom package) and it seems to fail with the following error:

Running on hyprland and latest nixos-unstable.

EDIT: seems to work when downgrading electron to electron_24

[tschai-yim]

I tried to use this (by copy pasting the modified file into my packages directory and then importing the custom package) and it seems to fail with the following error:

@Suyashtnt you might wanna test it with the master not nixos-unstable branch. For me both work only with the runtime library and/or the feature flag

[alexandru0-dev]

I tried to use this (by copy pasting the modified file into my packages directory and then importing the custom package) and it seems to fail with the following error:.
EDIT: seems to work when downgrading electron to electron_24

same but i'm stable 23.11. Using electron_24 solves the issues

[niknetniko]

Works for me

[tschai-yim]

Can we merge this PR? All users that reported a problem either used the wrong version or are not providing further details to see if it's actually an issue with this PR. For niknetniko and me, this patch works and was already proven to work in other chromium apps.

It was still logging some errors for me when starting obsidian but rebasing to the newest master state fixed all these issues.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1471

[SuperSandro2000]

Proper fix will be in #285883