Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liquidctl: fix test for pillow ≥ 10.2.0 #288085

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

evils
Copy link
Member

@evils evils commented Feb 11, 2024

issue described upstream in
liquidctl/liquidctl#661

Description of changes

added patch linked in upstream issue
(liquidctl/liquidctl@c50afa4)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@evils evils changed the title liquidctl: fix for pillow > 10.2.0 liquidctl: fix test for pillow > 10.2.0 Feb 11, 2024
@evils evils changed the title liquidctl: fix test for pillow > 10.2.0 liquidctl: fix test for pillow ≥ 10.2.0 Feb 11, 2024
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, nixpkgs-review happy, nixos x86_64

Co-authored-by: Robert Scott <github@humanleg.org.uk>
@Kranzes Kranzes merged commit fda93f9 into NixOS:master Feb 12, 2024
23 checks passed
@Kranzes Kranzes added the backport release-23.11 Backport PR automatically label Feb 12, 2024
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-288085-to-release-23.11 origin/release-23.11
cd .worktree/backport-288085-to-release-23.11
git switch --create backport-288085-to-release-23.11
git cherry-pick -x b586e93eac91d7feb416cda8c59b735ba2ae47b2 0aa480f30ac192ab4bb41c0507e05a82f73fc278

@evils
Copy link
Member Author

evils commented Feb 12, 2024

manual backport already in place at #288100

@codifryed codifryed mentioned this pull request Feb 12, 2024
12 tasks
Emantor pushed a commit to Emantor/nixpkgs that referenced this pull request Feb 13, 2024
* liquidctl: fix test for pillow ≥ 10.2.0

issue described upstream in
  liquidctl/liquidctl#661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants