-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.11] liquidctl: fix test for pillow ≥ 10.2.0 #288100
Conversation
issue described upstream in liquidctl/liquidctl#661 manually backported for 23.11 where there's still SETUPTOOLS_SCM_PRETEND_VERSION which was removed as redundant on master shortly after 23.11
d496ccb
to
b1ceabd
Compare
@Kranzes why did you close this? |
Oh I thought It was a duplicate of the other branch. I guess that's why you should follow CONTRIBUTING.md properly and name your PR accordingly. If you ever want to backport a PR just add the backport label to it and a GitHub Action will handle creating the backport PR. |
i knew about the github action, that's not applicable here as the commits in the other PR don't apply cleanly to the 23.11 branch i did read the relevant section in CONTRIBUTING.md, but apparently stopped reading when it clarified what branch to target after saying i should use the regular PR rules to create the backport (which i assumed included the unabridged rules about titling) |
please read CONTRIBUTING.md before changing my title |
You're right, my bad. There seems to be some inconsistencies between the Github Action and the CONTRIBUTING.md. |
issue described upstream in
liquidctl/liquidctl#661
Description of changes
added patch linked in upstream issue
(liquidctl/liquidctl@c50afa4)
Things done
manual backport of #288085
verified this does not break liquidctl before #284251 gets to 23.11
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usagenixpkgs-review failed to automatically merge ¯\_(ツ)_/¯
./result/bin/
)Add a 👍 reaction to pull requests you find important.