Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

loramon: init at 0.9.7 #289391

Merged
merged 2 commits into from Feb 28, 2024
Merged

loramon: init at 0.9.7 #289391

merged 2 commits into from Feb 28, 2024

Conversation

Erethon
Copy link
Contributor

@Erethon Erethon commented Feb 16, 2024

Description of changes

Add myself as a maintainer and init the LoRaMon package.

Git repository: https://github.com/markqvist/LoRaMon
LoRaMon is a packet sniffer for LoRa radio packets using cheap hardware devices. This package is somewhat related to the reticulum and nomadnet packages already present in nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@qbit
Copy link
Contributor

qbit commented Feb 17, 2024

Result of nixpkgs-review pr 289391 run on x86_64-linux 1

2 packages built:
  • loramon
  • loramon.dist

pkgs/by-name/lo/loramon/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/loramon/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/loramon/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/lo/loramon/package.nix Show resolved Hide resolved
@qbit
Copy link
Contributor

qbit commented Feb 17, 2024

Result of nixpkgs-review pr 289391 run on x86_64-linux 1

2 packages built:
  • loramon
  • loramon.dist

@qbit
Copy link
Contributor

qbit commented Feb 17, 2024

Runs as expected!

Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks and welcome to nixpkgs!

@jnsgruk jnsgruk merged commit 86849ab into NixOS:master Feb 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants