Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.spsdk: 2.0.1 -> 2.1.0 #289865

Merged
merged 6 commits into from
Mar 5, 2024
Merged

python311Packages.spsdk: 2.0.1 -> 2.1.0 #289865

merged 6 commits into from
Mar 5, 2024

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 18, 2024 •
edited
Loading

Description of changes

fixes #289860

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@patka-123
Copy link
Contributor

patka-123 commented Feb 18, 2024 •
edited
Loading

This doesn't fix the build. Please build stuff before stating it fixes something.

Result of nixpkgs-review pr 289865 run on x86_64-linux 1

6 packages failed to build:
  • nitrokey-app2
  • nitrokey-app2.dist
  • pynitrokey (python311Packages.pynitrokey)
  • pynitrokey.dist (python311Packages.pynitrokey.dist)
  • python311Packages.spsdk
  • python311Packages.spsdk.dist

@dotlambda dotlambda marked this pull request as draft February 19, 2024 00:30
@dotlambda dotlambda changed the title python311Packages.spsdk: relax cryptography constraint python311Packages.spsdk: 2.0.1 -> 2.1.0 Feb 19, 2024
@ofborg ofborg bot requested a review from tbenst February 19, 2024 04:03
@dotlambda dotlambda marked this pull request as ready for review February 19, 2024 17:10
@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 289865 run on x86_64-linux 1

6 packages marked as broken and skipped:
  • nitrokey-app2
  • nitrokey-app2.dist
  • python311Packages.pynitrokey
  • python311Packages.pynitrokey.dist
  • python311Packages.spsdk
  • python311Packages.spsdk.dist
10 packages built:
  • pynitrokey
  • pynitrokey.dist
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist
  • python311Packages.nbdime
  • python311Packages.nbdime.dist
  • python311Packages.pyocd-pemicro
  • python311Packages.pyocd-pemicro.dist
  • python311Packages.pytest-notebook
  • python311Packages.pytest-notebook.dist

@marzipankaiser
Copy link
Contributor

This does not seem to fix the build of pynitrokey for me:
https://gist.github.com/marzipankaiser/821e5f20cee2098310b5b6382565f779

@dotlambda
Copy link
Member Author

That might be a flaky test. Please re-run.

@marzipankaiser
Copy link
Contributor

marzipankaiser commented Feb 20, 2024 •
edited
Loading

Does not seem to be a flaky test, just re-ran it 20 times, all of which failed consistently (also added to https://gist.github.com/marzipankaiser/821e5f20cee2098310b5b6382565f779 )

It might be performance-related, though 🤔

@999eagle
Copy link
Contributor

999eagle commented Feb 20, 2024 •
edited
Loading

Using nixpkgs-review I get a build (or rather test) failure for python311Packages.eventlet which is a transitive dependency for python311Packages.spsdk. Same failure happens if I directly check out 699c68b and try building pynitrokey. Looks to be the same failure @marzipankaiser encountered, so it's most likely not a flaky test.

Here's the build log: https://gist.github.com/999eagle/19f3bca701091abf84eadd37430f88d3

EDIT: Huh. Interestingly enough, eventlet itself fails the exact same tests even when building it from the current nixos-unstable using nix-build -A python311Packages.eventlet --check. I think we're dealing with #288357 here. I've cherry-picked that PR onto this one and at least eventlet builds now. Everything else is still compiling. @dotlambda could it be that you're running a linux kernel older than 6.6? That might explain why it builds for you.

@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 289865 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.pynitrokey
  • python311Packages.pynitrokey.dist
  • python311Packages.spsdk
  • python311Packages.spsdk.dist
12 packages built:
  • nitrokey-app2
  • nitrokey-app2.dist
  • pynitrokey
  • pynitrokey.dist
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist
  • python311Packages.nbdime
  • python311Packages.nbdime.dist
  • python311Packages.pyocd-pemicro
  • python311Packages.pyocd-pemicro.dist
  • python311Packages.pytest-notebook
  • python311Packages.pytest-notebook.dist

@dotlambda
Copy link
Member Author

I think we're dealing with #288357 here. I've cherry-picked that PR onto this one and at least eventlet builds now. Everything else is still compiling. @dotlambda could it be that you're running a linux kernel older than 6.6? That might explain why it builds for you.

Indeed, I run 6.1 on my build server and I can reproduce the failure on kernel 6.7.

@dotlambda dotlambda mentioned this pull request Feb 20, 2024
Merged
13 tasks
SuperSandro2000
SuperSandro2000 reviewed Feb 20, 2024
View reviewed changes
pkgs/tools/security/nitrokey-app2/default.nix Show resolved Hide resolved
pkgs/development/python-modules/spsdk/default.nix Show resolved Hide resolved
pkgs/development/python-modules/spsdk/default.nix
pytestCheckHook
voluptuous
];

disabledTests = [
"test_nxpcrypto_create_signature_algorithm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this should get a short comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care enough about these packages to figure out why the test fails.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to figure out why but we should at least comment how they failed, otherwise we can't determine in the future, if things got fixed or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just run the test and see if it still fails?

pkgs/development/python-modules/pytest-notebook/default.nix
'';

disabledTests = [
"test_diff_to_string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also get a short comment

pkgs/development/python-modules/pytest-notebook/default.nix Show resolved Hide resolved
pkgs/development/python-modules/pytest-notebook/default.nix Show resolved Hide resolved
pkgs/development/python-modules/nbdime/default.nix
"test_inline_merge_cells_replacement"
"test_interrogate_filter_no_repo"
"test_merge_input_strategy_inline"
"test_git_diffdriver"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a short comment if we update the failed test list

@999eagle
Copy link
Contributor

Now that #288357 is available on master and nixos-unstable, I've tried building this again but now I always get hangs when testing debugpy (and this looks like #262000). I've let the tests run multiple times for multiple hours now and always had hangs at 23%. Maybe we could just override it in pynitrokey and nitrokeyapp2 to disable the tests?

@dotlambda
Copy link
Member Author

Result of nixpkgs-review pr 289865 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python311Packages.pynitrokey
  • python311Packages.pynitrokey.dist
  • python311Packages.spsdk
  • python311Packages.spsdk.dist
12 packages built:
  • nitrokey-app2
  • nitrokey-app2.dist
  • pynitrokey
  • pynitrokey.dist
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist
  • python311Packages.nbdime
  • python311Packages.nbdime.dist
  • python311Packages.pyocd-pemicro
  • python311Packages.pyocd-pemicro.dist
  • python311Packages.pytest-notebook
  • python311Packages.pytest-notebook.dist

@dotlambda dotlambda merged commit dacfe70 into NixOS:master Mar 5, 2024
23 checks passed
@dotlambda dotlambda deleted the spsdk-cryptography branch March 5, 2024 03:44
@999eagle
Copy link
Contributor

999eagle commented Mar 5, 2024

Not sure this should've been merged yet as the build still hangs on the tests in debugpy. Maybe if we could make sure all the free packages (i.e. everything except pypemicro I think) are actually built by hydra this would've been okay.

@dotlambda
Copy link
Member Author

Before this PR spsdk was broken so this definitely doesn't make the situation worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marzipankaiser marzipankaiser marzipankaiser left review comments

@frogamic frogamic Awaiting requested review from frogamic

@sbruder sbruder Awaiting requested review from sbruder

@panicgh panicgh Awaiting requested review from panicgh

@tbenst tbenst Awaiting requested review from tbenst

@999eagle 999eagle Awaiting requested review from 999eagle

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: pynitrokey (spsdk)
5 participants
@dotlambda @patka-123 @marzipankaiser @999eagle @SuperSandro2000