Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

c2patool: init at 0.8.2 #292020

Merged
merged 2 commits into from Apr 9, 2024
Merged

c2patool: init at 0.8.2 #292020

merged 2 commits into from Apr 9, 2024

Conversation

ok-nick
Copy link
Member

@ok-nick ok-nick commented Feb 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ok-nick
Copy link
Member Author

ok-nick commented Feb 28, 2024

May additionally compile fine on Linux, have yet to test.

@ok-nick
Copy link
Member Author

ok-nick commented Feb 28, 2024

Looks like it builds fine on Linux, I鈥檒l add it to supported platforms later today

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3597

pkgs/tools/misc/c2patool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/c2patool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/c2patool/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/c2patool/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cleanup the commit history according to the contributing guide.

@ok-nick
Copy link
Member Author

ok-nick commented Mar 25, 2024

@mweinelt Sorry about that, rebased too far back

@mweinelt mweinelt removed their request for review March 25, 2024 02:01
@ok-nick ok-nick marked this pull request as ready for review March 25, 2024 02:02
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not using pkgs/by-name and the package is not loaded automatically. The easiest is, if you move the files and rename default to package.nix and then try building it locally.

@SuperSandro2000
Copy link
Member

The x86_64-linux build is failing:

running 5 tests
test signer::tests::test_sign_config ... ok
test signer::tests::test_sign_from ... ok
test signer::tests::test_sign_default ... ok
test info::tests::test_manifest_config ... ok
test tests::test_manifest_config ... FAILED
failures:
---- tests::test_manifest_config stdout ----
thread 'tests::test_manifest_config' panicked at src/main.rs:389:14:
embed: CoseTimeStampGeneration
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    tests::test_manifest_config
test result: FAILED. 4 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
error: test failed, to rerun pass `--bin c2patool`
error: builder for '/nix/store/zjrrkh32q4rwc5f7sc1h0a0zqwhj5rbk-c2patool-0.7.0.drv' failed with exit code 101;

@ok-nick ok-nick changed the title c2patool: init at 0.7.0 c2patool: init at 0.8.2 Apr 2, 2024
@ok-nick
Copy link
Member Author

ok-nick commented Apr 2, 2024

Some tests try to send network requests to http://timestamp.digicert.com, which isn't allowed in a sandboxed build. I've disabled them for now.

@ok-nick
Copy link
Member Author

ok-nick commented Apr 8, 2024

@SuperSandro2000 Let me know if there is anything else.

@SuperSandro2000 SuperSandro2000 merged commit a76c455 into NixOS:master Apr 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants