New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
c2patool: init at 0.8.2 #292020
c2patool: init at 0.8.2 #292020
Conversation
May additionally compile fine on Linux, have yet to test. |
Looks like it builds fine on Linux, I鈥檒l add it to supported platforms later today |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cleanup the commit history according to the contributing guide.
e915cd7
to
95f3270
Compare
@mweinelt Sorry about that, rebased too far back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not using pkgs/by-name and the package is not loaded automatically. The easiest is, if you move the files and rename default to package.nix and then try building it locally.
The x86_64-linux build is failing:
|
Some tests try to send network requests to http://timestamp.digicert.com, which isn't allowed in a sandboxed build. I've disabled them for now. |
@SuperSandro2000 Let me know if there is anything else. |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.