Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libredirect: don't test LFS64 functions on musl #292616

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Mar 1, 2024

Description of changes

These were removed in musl 1.2.4.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label Mar 1, 2024
@alyssais alyssais mentioned this pull request Mar 1, 2024
47 tasks
These were removed in musl 1.2.4.
@SuperSandro2000 SuperSandro2000 merged commit 0c448ca into NixOS:staging Mar 2, 2024
26 checks passed
@alyssais alyssais deleted the libredirect-LFS64 branch May 15, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants