pyp: 1.1.0 -> 1.2.0 #292693
pyp: 1.1.0 -> 1.2.0 #292693
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3598 |
There was a problem hiding this comment.
The upstream's diff looks fine to me.
hauntsaninja/pyp@v1.1.0...v1.2.0
Do we even need that? Is this a library you can import? I couldn't find something in the readme. |
- Merge and refactor the two packages - pyp and python3Packages.pyp should be the same file! - set bc and jq appropriately - get rid of rec - get rid of nested with - set pyproject - set meta.mainProgram
Since it is not used as library, it makes no sense to deploy it as a library.
It is a long history... But indeed you are correct. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1515 |
|
Same for 23.11? It also doesn't build there now, looked like the same cause: |
|
Do you suggest a backport? Lemme see what the bot says... |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-292693-to-release-23.11 origin/release-23.11
cd .worktree/backport-292693-to-release-23.11
git switch --create backport-292693-to-release-23.11
git cherry-pick -x 9f3840785bed83234dd27b293ad30b38e4aece29 5211205ca9a44c3eff29c940d4238bd87aa733fc d6599f77f65c65cfb4dac3dd8eec52f21bd4e6ce cd975261c7594517908b1c39d39a9197baf3b28d |
Description of changes
Closes #286964 and #294107 until better idea
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.