[23.11] pyp: 1.1.0 -> 1.2.0 #297597
Merged
[23.11] pyp: 1.1.0 -> 1.2.0 #297597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3664 |
|
I see errors in ofborg. |
- Merge and refactor the two packages - pyp and python3Packages.pyp should be the same file! - set bc and jq appropriately - get rid of rec - get rid of nested with - set pyproject - set meta.mainProgram (cherry picked from commit 9f38407)
(cherry picked from commit 5211205)
(cherry picked from commit d6599f7)
Since it is not used as library, it makes no sense to deploy it as a library. (cherry picked from commit cd97526)
AndersonTorres
force-pushed
the
backport-pyp-120-to-release-23.11
branch
from
2e808da
to
63efbf8
Compare
Because it is not existent on the past.
AndersonTorres
commented
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
As requested by @vcunat at #292693 (comment)
Cleaning up my backlog...
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.