Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/sane: fix disabling backends which are subwords of other backends #293022

Conversation

symphorien
Copy link
Member

Fixes #292159

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@symphorien
Copy link
Member Author

ping @robinkrahl for testing

@drupol drupol merged commit 439832d into NixOS:master Jun 1, 2024
20 checks passed
@drupol
Copy link
Contributor

drupol commented Jun 1, 2024

Trusting you on this @symphorien , I haven't tested it myself... and since there's no other feedback so far, let's merge it. We'll get feedback very soon if something's broken anyway ;)

jvanbruegge added a commit to jvanbruegge/server-config that referenced this pull request Jun 21, 2024
Also update list of disabled scanner devices because of NixOS/nixpkgs#293022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sane: disabledDefaultBackends does not work reliably
2 participants