nixos/prometheus-fritz-exporter: init module #295417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyCodeGHG
force-pushed
the
nixos/fritz-exporter
branch
from
917c38e
to
7594e3b
Compare
Shawn8901
reviewed
Mar 16, 2024
NyCodeGHG
force-pushed
the
nixos/fritz-exporter
branch
2 times, most recently
from
5e81dec
to
e686b0b
Compare
Shawn8901
reviewed
Mar 17, 2024
NyCodeGHG
force-pushed
the
nixos/fritz-exporter
branch
from
e686b0b
to
578e7aa
Compare
Shawn8901
approved these changes
Mar 20, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3670 |
mweinelt
reviewed
Mar 23, 2024
nixos/modules/services/monitoring/prometheus/exporters/fritz.nix
Outdated
Show resolved
Hide resolved
NyCodeGHG
force-pushed
the
nixos/fritz-exporter
branch
from
578e7aa
to
f107cf8
Compare
NyCodeGHG
force-pushed
the
nixos/fritz-exporter
branch
from
f107cf8
to
88daab5
Compare
mweinelt
approved these changes
Mar 23, 2024
|
Everything good on your end? |
yes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
adds a new module for the prometheus
fritz-exporterpackage.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.