-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.radios: 0.3.0 -> 0.3.1 #295505
Conversation
@mweinelt Would you prefer I move the pycountry commit to staging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the rationale for some changes. Could the commit messages detail them a bit?
Also, is there any relationship between these commits?
pyproject = true; | ||
|
||
disabled = pythonOlder "3.8"; | ||
|
||
src = fetchFromGitHub { | ||
owner = pname; | ||
repo = pname; | ||
owner = "xhtml2pdf"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because semantically they're not the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -55,17 +51,18 @@ buildPythonPackage rec { | |||
pyyaml | |||
requests | |||
rich | |||
termcolor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing these dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we always miss things in the python-updates bulk update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I searched the upstream code for the dependency and couldn't find it.
|
||
disabled = pythonOlder "3.7"; | ||
|
||
src = fetchFromGitLab { | ||
owner = "woob"; | ||
repo = pname; | ||
repo = "woob"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, we are still early enough in staging-next. |
They all came up as broken after trying to update pycountry. |
Description of changes
Diff: frenck/python-radios@v0.3.0...v0.3.1
Changelog: https://github.com/frenck/python-radios/releases/tag/v0.3.1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.