-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
softether: 4.18 -> 4.20 #29781
softether: 4.18 -> 4.20 #29781
Conversation
@@ -11638,7 +11638,8 @@ with pkgs; | |||
oracleXE = callPackage ../servers/sql/oracle-xe { }; | |||
|
|||
softether_4_18 = callPackage ../servers/softether/4.18.nix { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep 4.18 around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add services.softether.package
option for this, we could use this version when we got something wrong in new version.
Why don't you update to 4.22? |
@orivej the 4.22 version is beta, I am not sure that version is stable or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this page says that 4.22 is beta and 4.20 is a release: http://www.softether.org/5-download/history
wantedBy = [ "multi-user.target" ]; | ||
after = [ "softether-init.service" ]; | ||
requires = [ "softether-init.service" ]; | ||
wantedBy = [ "network-interfaces.target" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace network-interfaces.target
with network.target
: #18491
Please confirm that it works as you expect afterwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orivej Oops, thank you for reviewed that, I have replaced.
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)