-
-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xivlauncher: Fix GameMode not being detected #299304
Conversation
I've created #299524 as a possibly better way of fixing this issue, still a draft PR as I need to test it. |
I've not made any progress with getting this to work. If the maintainers are fine with this solution, feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been running an identical override for months and this does work fine. The module approach in the other PR seems a bit complex/messy and I don't feel it's necessary. Have you tested this PR on a system without gamemoded enabled?
As for dependencies, IMO making this dependency optional with a useGamemode argument to the derivation seems appropriate. |
Disabling GameMode causes a prompt to appear to give permission to GameMode to do its thing. Unfortunately, this then takes over GNOME Shell and XIVLauncher has to be force-killed in a separate TTY. |
I've had zero success with getting this to work. |
I'm continuing to work on making GameMode optional, will test again today hopefully |
61d838c
to
c1700de
Compare
c1700de
to
bf514a1
Compare
Works with an override now, this PR should be ready for review now |
observation: enabling this flag without gamemode running system-wide causes a substantial amount of logspam when viewing the settings page, if you have the launcher's gamemode option enabled, along the lines of:
|
This was one of my concerns, enabling GameMode in the package without it being enabled system-wide has some bad effects (see #299304 (comment)). |
I've been thinking about this, and I can't really see a way to avoid someone enabling GameMode within XIVLauncher without it being enabled system-wide.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3833 |
Description of changes
Fix XIVLauncher not detecting GameMode.
According to the documentation for the NativeLibrary.TryLoad method and DllImportSearchPath enum (used by XIVLauncher to detect GameMode) the library search path used by .NET is fairly static. As XIVLauncher runs inside of a
steam-run
wrapper we can add GameMode to the FHS environment so that .NET can detect it.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.