Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x264: unstable-2021-06-13 -> 0-unstable-2023-10-01 #300980

Merged
merged 1 commit into from
Apr 3, 2024
Merged

x264: unstable-2021-06-13 -> 0-unstable-2023-10-01 #300980

merged 1 commit into from
Apr 3, 2024

Conversation

Kamillaova
Copy link
Contributor

@Kamillaova Kamillaova commented Apr 2, 2024 •
edited
Loading

Description of changes

https://code.videolan.org/videolan/x264/-/tree/stable

Also closes #224609 and #282371

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from tadeokondrak April 2, 2024 15:42
@Kamillaova Kamillaova changed the base branch from master to staging April 2, 2024 18:15
@Kamillaova Kamillaova marked this pull request as ready for review April 2, 2024 18:43
tadeokondrak
tadeokondrak approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@tadeokondrak tadeokondrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good

@Kamillaova Kamillaova changed the title x264: unstable-2021-06-13 -> unstable-2023-10-01 x264: unstable-2021-06-13 -> 0-unstable-2023-10-01 Apr 3, 2024
@ofborg ofborg bot requested a review from tadeokondrak April 3, 2024 10:51
@wegank wegank merged commit 1f08e55 into NixOS:staging Apr 3, 2024
25 of 27 checks passed
@SuperSandro2000 SuperSandro2000 mentioned this pull request May 2, 2024
Closed
@Kamillaova Kamillaova mentioned this pull request May 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

@tadeokondrak tadeokondrak Awaiting requested review from tadeokondrak

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 2 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kamillaova @tadeokondrak @wegank