Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromedriver,{,ungoogled-}chromium: 123.0.6312.{86,105} -> 123.0.6312.122 #303377

Merged
merged 3 commits into from Apr 11, 2024

Conversation

networkException
Copy link
Member

Description of changes

https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop_10.html

This update includes 3 security fixes.

CVEs:
CVE-2024-3157 CVE-2024-3516 CVE-2024-3515

Things done

  • Built on platform(s)
    • x86_64-linux (only ungoogled-chromium)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/) (only ungoogled-chromium)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@emilylange emilylange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 303377 run on x86_64-linux 1

25 packages built:
  • aws-azure-login
  • chromedriver
  • chromium
  • chromium.sandbox
  • fast-cli
  • google-chrome
  • mermaid-cli
  • mermaid-filter
  • netflix
  • percollate
  • playwright-test
  • puppeteer-cli
  • python311Packages.pytest-playwright
  • python311Packages.pytest-playwright.dist
  • python312Packages.pytest-playwright
  • python312Packages.pytest-playwright.dist
  • selendroid
  • selenium-server-standalone
  • sharedown
  • single-file-cli
  • sitespeed-io
  • ungoogled-chromium
  • ungoogled-chromium.sandbox
  • vhs
  • wayback

# git describe --abbrev=40
24.05-pre-59285-gf59f29659e1db1130f87936ef9f2a11a71b3a99c

# nix-build nixos/tests/chromium.nix -A stable -A ungoogled
/nix/store/n0c326jbf1rgclf6sl46dacqb7bkblas-vm-test-run-chromium-stable
/nix/store/x7q05bbc1jmnnpinnvls7yhy0hhvqnif-vm-test-run-chromium-ungoogled

@emilylange emilylange merged commit d9e698c into NixOS:master Apr 11, 2024
29 checks passed
Copy link
Contributor

hash = "sha256-81SoZBOAAV0cAVzz3yOzBstRW3vWjmkFoFNjYdPnme4=";
rev = "123.0.6312.105-1";
hash = "sha256-ojKIAkJB/gfg6scCxUYNAGx4lsquAaCySBDcUCFLqSU=";
rev = "d5773b0fb696ef107cc6df6a94cbe732c9e905f9";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally used the commit on master here instead of the proper tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants