New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.fontbakery: 0.11.2 -> 0.12.2 #303622
python311Packages.fontbakery: 0.11.2 -> 0.12.2 #303622
Conversation
Looks like the update itself is okay, all the package unit tests are passing. The diff --git a/pkgs/development/python-modules/fontbakery/tests.nix b/pkgs/development/python-modules/fontbakery/tests.nix
index 4725b1fee3e3..d968d6ec056d 100644
--- a/pkgs/development/python-modules/fontbakery/tests.nix
+++ b/pkgs/development/python-modules/fontbakery/tests.nix
@@ -10,13 +10,10 @@ runCommand "${pname}-tests" { meta.timeout = 5; } ''
# Check the version matches what we packaged.
${fontbakery}/bin/fontbakery --version | grep -q "${version}"
- # Can it list its own subcommands?
- ${fontbakery}/bin/fontbakery --list-subcommands >>$out
-
# Unpack src to get some test fonts.
tar -xzf ${src} --strip-components=1 ${pname}-${version}/data/test
# Run some font checks.
- ${fontbakery}/bin/fontbakery check-ufo-sources --no-progress --no-colors data/test/test.ufo >>$out
+ ${fontbakery}/bin/fontbakery check-ufo --no-progress --no-colors data/test/test.ufo >>$out
# TODO add more
'' |
ca257c8
to
b210119
Compare
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript. meta.description for python311Packages.fontbakery is: Tool for checking the quality of font projects meta.homepage for python311Packages.fontbakery is: https://github.com/googlefonts/fontbakery Updates performed
To inspect upstream changesImpactChecks done
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.) Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build resultsWe have automatically built all packages that will get rebuilt due to This gives evidence on whether the upgrade will break dependent packages. Result of 2 packages failed to build:
2 packages built:
Maintainer pings |
This got rolled into PR #305152 so it's on |
Fixes are in PR #307382. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.fontbakery is: Tool for checking the quality of font projects
meta.homepage for python311Packages.fontbakery is: https://github.com/googlefonts/fontbakery
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
did not passRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'
run on x86_64-linux 12 packages failed to build:
2 packages built:
Maintainer pings
cc @danc86 for testing.