Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.fontbakery: 0.11.2 -> 0.12.2 #303622

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python311Packages.fontbakery is: Tool for checking the quality of font projects

meta.homepage for python311Packages.fontbakery is: https://github.com/googlefonts/fontbakery

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 0.12.0 with grep in /nix/store/r9nv2hlry3vck050a0ypycvc432ri37r-python3.11-fontbakery-0.12.0
  • found 0.12.0 in filename of file in /nix/store/r9nv2hlry3vck050a0ypycvc432ri37r-python3.11-fontbakery-0.12.0

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
fontbakery
python311Packages.fontbakery
python312Packages.fontbakery
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/r9nv2hlry3vck050a0ypycvc432ri37r-python3.11-fontbakery-0.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python311Packages.fontbakery https://github.com/r-ryantm/nixpkgs/archive/ca257c817720e1de9db15bc4b34d8336281e6068.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/ca257c817720e1de9db15bc4b34d8336281e6068#python311Packages.fontbakery

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/r9nv2hlry3vck050a0ypycvc432ri37r-python3.11-fontbakery-0.12.0
ls -la /nix/store/r9nv2hlry3vck050a0ypycvc432ri37r-python3.11-fontbakery-0.12.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:
  • python312Packages.fontbakery
  • python312Packages.fontbakery.dist
2 packages built:
  • fontbakery (python311Packages.fontbakery)
  • fontbakery.dist (python311Packages.fontbakery.dist)

Maintainer pings

cc @danc86 for testing.

@danc86
Copy link
Contributor

danc86 commented Apr 12, 2024

Looks like the update itself is okay, all the package unit tests are passing. passthru.tests is failing because of some changes in the command-line interface.

The check-ufo-sources subcommand got renamed to check-ufo. And the --list-subcommands option no longer exists (not sure if this change was intentional upstream, or a bug). We can fix this in the test script:

diff --git a/pkgs/development/python-modules/fontbakery/tests.nix b/pkgs/development/python-modules/fontbakery/tests.nix
index 4725b1fee3e3..d968d6ec056d 100644
--- a/pkgs/development/python-modules/fontbakery/tests.nix
+++ b/pkgs/development/python-modules/fontbakery/tests.nix
@@ -10,13 +10,10 @@ runCommand "${pname}-tests" { meta.timeout = 5; } ''
   # Check the version matches what we packaged.
   ${fontbakery}/bin/fontbakery --version | grep -q "${version}"

-  # Can it list its own subcommands?
-  ${fontbakery}/bin/fontbakery --list-subcommands >>$out
-
   # Unpack src to get some test fonts.
   tar -xzf ${src} --strip-components=1 ${pname}-${version}/data/test

   # Run some font checks.
-  ${fontbakery}/bin/fontbakery check-ufo-sources --no-progress --no-colors data/test/test.ufo >>$out
+  ${fontbakery}/bin/fontbakery check-ufo --no-progress --no-colors data/test/test.ufo >>$out
   # TODO add more
 ''

@r-ryantm r-ryantm force-pushed the auto-update/python311Packages.fontbakery branch from ca257c8 to b210119 Compare April 18, 2024 03:03
@r-ryantm r-ryantm changed the title python311Packages.fontbakery: 0.11.2 -> 0.12.0 python311Packages.fontbakery: 0.11.2 -> 0.12.2 Apr 18, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python311Packages.fontbakery is: Tool for checking the quality of font projects

meta.homepage for python311Packages.fontbakery is: https://github.com/googlefonts/fontbakery

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 0.12.2 with grep in /nix/store/4fhvyni1l9ywv7a1p0ixlh9x9j2g0swv-python3.11-fontbakery-0.12.2
  • found 0.12.2 in filename of file in /nix/store/4fhvyni1l9ywv7a1p0ixlh9x9j2g0swv-python3.11-fontbakery-0.12.2

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
fontbakery
python311Packages.fontbakery
python312Packages.fontbakery
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/4fhvyni1l9ywv7a1p0ixlh9x9j2g0swv-python3.11-fontbakery-0.12.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python311Packages.fontbakery https://github.com/r-ryantm/nixpkgs/archive/b210119c62ff84a745d6e25d42cfc242e8cfa94e.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/b210119c62ff84a745d6e25d42cfc242e8cfa94e#python311Packages.fontbakery

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/4fhvyni1l9ywv7a1p0ixlh9x9j2g0swv-python3.11-fontbakery-0.12.2
ls -la /nix/store/4fhvyni1l9ywv7a1p0ixlh9x9j2g0swv-python3.11-fontbakery-0.12.2/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:
  • python312Packages.fontbakery
  • python312Packages.fontbakery.dist
2 packages built:
  • fontbakery (python311Packages.fontbakery)
  • fontbakery.dist (python311Packages.fontbakery.dist)

Maintainer pings

cc @danc86 for testing.

@danc86
Copy link
Contributor

danc86 commented Apr 28, 2024

This got rolled into PR #305152 so it's on staging already. Will send a new PR to fix the passthru.tests and other broken deps.

@danc86 danc86 closed this Apr 28, 2024
@danc86
Copy link
Contributor

danc86 commented Apr 28, 2024

Fixes are in PR #307382.

@r-ryantm r-ryantm deleted the auto-update/python311Packages.fontbakery branch April 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants