commafeed: init at 4.3.3 #304257
Merged
commafeed: init at 4.3.3 #304257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3822 |
Comment on lines
5
to
13
| gitProperties = writeText "git.properties" ( | ||
| '' | ||
| git.branch = none | ||
| git.build.time = 1970-01-01T00:00:00+0000 | ||
| git.build.version = ${common.version} | ||
| git.commit.id = none | ||
| git.commit.id.abbrev = none | ||
| '' | ||
| ); |
There was a problem hiding this comment.
Suggested change
| gitProperties = writeText "git.properties" ( | |
| '' | |
| git.branch = none | |
| git.build.time = 1970-01-01T00:00:00+0000 | |
| git.build.version = ${common.version} | |
| git.commit.id = none | |
| git.commit.id.abbrev = none | |
| '' | |
| ); | |
| gitProperties = writeText "git.properties" '' | |
| git.branch = none | |
| git.build.time = 1970-01-01T00:00:00+0000 | |
| git.build.version = ${common.version} | |
| git.commit.id = none | |
| git.commit.id.abbrev = none | |
| ''; |
pkgs/by-name/co/commafeed/common.nix
Outdated
Comment on lines
15
to
17
| npmDepsHash = "sha256-fye7MPWXUeFCMgcnesspd1giGG/ZldiOv00fjtXZSb4="; | ||
|
|
||
| mvnHash = "sha256-YnEDJf4GeyiXxOh8tZZTZdLOJrisG6lmShXU97ueGNE="; |
There was a problem hiding this comment.
It would probably be easier and simpler if the hashes where at the specific package and the src is just inherited from the main package into the frontent.
There was a problem hiding this comment.
I moved everything to package.nix. After your comment I came to the conclusion that using separate files in this package doesn't give anything special. 1 file is simpler.
|
Additionally I formatted this PR using |
SuperSandro2000
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds CommaFeed package and module.
Link: https://github.com/Athou/commafeed
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.