Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vibrantlinux: 2.1.10 -> 2.2.0 #304265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Scrumplex
Copy link
Member

@Scrumplex Scrumplex commented Apr 15, 2024

Description of changes

Upgrades to the recently released vibrantLinux and libvibrant versions.

I (upstream developer) have switched vibrantLinux to CMake and did some big refactorings to improve the overall code quality and fix some issues. This software now also starts on systems that are not supported, with a user-friendly message telling them about the problem.

libvibrant now ships a pkg-config manifest to improve the packaging process of that.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@unclamped
Copy link
Contributor

ey! I just opened GitHub after a bit.
I have moved to Mint because of IRL issues with me not being able to afford much time at tinkering with NixOS and doing as much experimentation as I'd want to :S
I will try to install Nix here and attempt to build the pkg, but yeah, I'm sorry for not being able to keep much track of my pkgs now :(

@Scrumplex
Copy link
Member Author

No pressure ^^
I have added myself as maintainer to these two packages so at least for these, you shouldn't have to worry too much :D

There also won't be many more updates to the software for the foreseeable future, so it's fairly low maintenance anyway :D

@Scrumplex Scrumplex force-pushed the pkgs/vibrantlinux/2.2.0 branch 2 times, most recently from 17bb480 to c95a402 Compare June 30, 2024 18:49
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4364

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants