-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meliae: init at 0.4.0 #30508
meliae: init at 0.4.0 #30508
Conversation
8b9eedf
to
4c8d306
Compare
pkgs/top-level/python-packages.nix
Outdated
@@ -11650,6 +11650,10 @@ in { | |||
}; | |||
}; | |||
|
|||
meliae = if ! isPy3k then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use disabled = isPy3k;
in the expression instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks. I've squashed both changes and --force pushed.
sha256 = "16gcgjzcjlbfarwlj18fn089bz34kzfw8varbzxsi9ma0amijrcp"; | ||
}; | ||
|
||
checkInputs = [ cython ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed if it is already in propagatedBuildInputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test runner doesn't find any tests. Either fix the test discovery, or, if there are no tests, disable tests and include a comment about it.
@FRidh Fixed and squashed. |
Motivation for this change
To update Tribler from 7.0.0-rc2 to 7.0.0-rc3 we need this new dependency
Things done
Added meliae 0.4.0 to pyhonPackages.
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)