Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildDotnetModule: fix PublishAOT failing on .NET7 and above #306161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamcstephens
Copy link
Contributor

Description of changes

The necessary libraries require patchelf to successfully publish a
Native AOT package.

jitinterface_x64.so: cannot open shared object file: No such file or directory

Extracted from #267743 . I don't know the tests, but this patchelf alone unbreaks PublishAOT packaging.

Closes: #280923

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

The necessary libraries require patchelf to successfully publish a
Native AOT package.

jitinterface_x64.so: cannot open shared object file: No such file or directory
@corngood
Copy link
Contributor

In patch-nupkgs we do --add-rpath instead of --set-rpath. I wonder if we should do the same here?

--add-rpath "${binaryRPath}" \

I do plan on unifying all this package patching stuff at some point.

Also I'm currently working on a minimal AOT test:

corngood@dotnet-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] buildDotnetModule fails to publish with -p:PublishAot=true
4 participants