Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tailscale-derper: init #306533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Apr 24, 2024

Description of changes

inlcudes #306532

when I am done figuring out how to setup derp completely, I will probably do a PR for a module.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@danderson danderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, @ me when you want a review of the nixos module? If you'd like to merge the packaging change and do the module separately, that's also fine by me.

I assume you've found it already, but https://tailscale.com/kb/1118/custom-derp-servers has some orientation on how to run derper. It may also be worth linking to from the module docs?

Also worth noting that tailscale doesn't provide any support for running custom derp, unless you're paying enterprise kind of money. I'm not sure if that's worth mentioning in the nixos module or not, I can't tell how many people would use this and how many would try to file support tickets. I'm ok with it either way.

@SuperSandro2000
Copy link
Member Author

Also worth noting that tailscale doesn't provide any support for running custom derp, unless you're paying enterprise kind of money. I'm not sure if that's worth mentioning in the nixos module or not, I can't tell how many people would use this and how many would try to file support tickets. I'm ok with it either way.

It works with headscale :)

@SuperSandro2000
Copy link
Member Author

@danderson I've added a module. I've extracted it from my config and I think I didn't miss anything.

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review May 5, 2024 22:54
@SuperSandro2000 SuperSandro2000 changed the title tailscale: build derper nixos/tailscale-derper: init May 8, 2024
@SuperSandro2000
Copy link
Member Author

I assume you've found it already, but tailscale.com/kb/1118/custom-derp-servers has some orientation on how to run derper. It may also be worth linking to from the module docs?

Is that page hidden from search engines?


I've been running the setup for a bit now and I think it is ready and stable and works good.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4216

@@ -0,0 +1,114 @@
{ config, lib, pkgs, ... }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some nixfmt-rfc-style. 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants