-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-vanity-hash: fix build and execution #306993
Conversation
# Broken due to ancient dependency rusc-serialize | ||
# https://hydra.nixos.org/build/256865980/nixlog/2 | ||
# Potential fix submitted upstream | ||
# https://github.com/prasmussen/git-vanity-hash/pull/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not fetch the patch instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give it a try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to patch this, but it won't build complaining about wrong cargoHash. I updated it as usual, but it's still failing. I asked for some tips about the issue, and will gladly accept any help on this @SuperSandro2000! Thanks in advance!
It builds now.
db7678e
to
1f817ce
Compare
1f817ce
to
854f6d1
Compare
Build has been broken in Hydra. Potential cause seems to be an old dependency, with a possible workaround sent upstream. Patch the workaround for now.
854f6d1
to
59e27c1
Compare
Thanks for the review @SuperSandro2000! |
Build has been broken in Hydra: https://hydra.nixos.org/build/256865980/nixlog/2.
Potential cause seems to be an old dependency, with a possible workaround sent upstream.
Description of changes
I left a PR to switch dependencies and work around the issue in prasmussen/git-vanity-hash#2.
Things done
Marking as broken with comments documenting the issue.Change the fetched rev of the package to pick up the upstreamed solution.
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.