git-vanity-hash: fix build and execution #306993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Broken due to ancient dependency rusc-serialize | ||
| # https://hydra.nixos.org/build/256865980/nixlog/2 | ||
| # Potential fix submitted upstream | ||
| # https://github.com/prasmussen/git-vanity-hash/pull/2 |
There was a problem hiding this comment.
Why not fetch the patch instead?
There was a problem hiding this comment.
I added a commit to patch this, but it won't build complaining about wrong cargoHash. I updated it as usual, but it's still failing. I asked for some tips about the issue, and will gladly accept any help on this @SuperSandro2000! Thanks in advance!
It builds now.
kiike
force-pushed
the
pkgs/git-vanity-hash
branch
from
db7678e
to
1f817ce
Compare
kiike
changed the title
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
kiike
force-pushed
the
pkgs/git-vanity-hash
branch
from
1f817ce
to
854f6d1
Compare
Build has been broken in Hydra. Potential cause seems to be an old dependency, with a possible workaround sent upstream. Patch the workaround for now.
kiike
force-pushed
the
pkgs/git-vanity-hash
branch
from
854f6d1
to
59e27c1
Compare
|
Thanks for the review @SuperSandro2000! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build has been broken in Hydra: https://hydra.nixos.org/build/256865980/nixlog/2.
Potential cause seems to be an old dependency, with a possible workaround sent upstream.
Description of changes
I left a PR to switch dependencies and work around the issue in prasmussen/git-vanity-hash#2.
Things done
Marking as broken with comments documenting the issue.Change the fetched rev of the package to pick up the upstreamed solution.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.