Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsively-desktop: init at 1.11.1 #307444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kashw2
Copy link
Contributor

@kashw2 kashw2 commented Apr 28, 2024

Description of changes

closes #304348

https://responsively.app/
https://github.com/responsively-org/responsively-app

Future plans are to introduce src based builds which will bring with it cross platform support, however upstream uses yarn lock v2 with support for such being tracked in #254369. As of current I am unable to assist in making this application available across other platforms bar x86_64-linux and aarch64-linux as i don't have a machine that supports other platforms.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@kashw2
Copy link
Contributor Author

kashw2 commented Apr 28, 2024

Result of nixpkgs-review pr 307444 run on x86_64-linux 1

1 package built:
  • responsively-desktop

pkgs/by-name/re/responsively-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/responsively-desktop/package.nix Outdated Show resolved Hide resolved
@kashw2 kashw2 force-pushed the responsively branch 3 times, most recently from a932fd3 to ff75402 Compare May 4, 2024 15:36
@kashw2 kashw2 changed the title responsively-desktop: init at 1.10.0 responsively-desktop: init at 1.11.1 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: responsively
3 participants