Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.rq: fix build on darwin #307790

Closed
wants to merge 1 commit into from
Closed

python3Packages.rq: fix build on darwin #307790

wants to merge 1 commit into from

Conversation

xanderio
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@xanderio xanderio mentioned this pull request Apr 29, 2024
Open
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 29, 2024
leona-ya
leona-ya reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit ugly, but as redis doesn't support listening on localhost with a cli parameter okay for me.

Please target against master. I said that incorrectly before, but 68a17d0 is in master.

maxbrunet
maxbrunet reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@maxbrunet maxbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it, could you set the attribute __darwinAllowLocalNetworking = true;, please? This will allow the package to build with the sandbox enabled. And target master like @leona-ya said, otherwise lgtm

@xanderio xanderio changed the base branch from staging-next to master April 30, 2024 08:20
leona-ya
leona-ya approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll merge when ofborg is also happy

@ofborg ofborg bot requested a review from MrMebelMan April 30, 2024 08:53
@leona-ya
Copy link
Member

@ofborg build python311Packages.rq python312Packages.rq

@pbsds
Copy link
Member

pbsds commented Jun 5, 2024

superseeded by #310861

@pbsds pbsds closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbrunet maxbrunet maxbrunet left review comments

@leona-ya leona-ya leona-ya approved these changes

@MrMebelMan MrMebelMan Awaiting requested review from MrMebelMan

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xanderio @leona-ya @pbsds @maxbrunet @wegank @Aleksanaa