Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open62541: 1.3.10 -> 1.4.1 #309053

Merged
merged 2 commits into from
Jun 4, 2024
Merged

open62541: 1.3.10 -> 1.4.1 #309053

merged 2 commits into from
Jun 4, 2024

Conversation

panicgh
Copy link
Contributor

@panicgh panicgh commented May 4, 2024

Description of changes

Upstream release and changelogs:

Unfortunately, unit tests now require a REUSEPORT option, which must not be used in production (open62541/open62541#6407). So I disable them by default and add another special build to passthru.tests.

Publish-Subscribe is now enabled, following the default in the upstream project.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@panicgh
Copy link
Contributor Author

panicgh commented May 6, 2024

I removed the suggested changes to meta.platforms from #233437, since some unit tests fail on Darwin.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3933

@panicgh panicgh added the backport release-24.05 Backport PR automatically label May 22, 2024
@panicgh panicgh changed the title open62541: 1.3.10 -> 1.4.0 open62541: 1.3.10 -> 1.4.1 May 25, 2024
@panicgh
Copy link
Contributor Author

panicgh commented May 25, 2024

@ofborg build open62541.tests

@SuperSandro2000 SuperSandro2000 merged commit 49e2a0a into NixOS:master Jun 4, 2024
23 of 24 checks passed
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants