Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maker-panel: bump dependency to fix compilation error #309507

Merged
merged 1 commit into from
May 6, 2024

Conversation

pluiedev
Copy link
Contributor

@pluiedev pluiedev commented May 6, 2024

Description of changes

One of the dependencies of this crate, num-bigint, fails to compile on Rust versions >=1.73 due to a name conflict (see rust-num/num-bigint#219).

This commit fixes the compilation failure by bumping the gerber-types dependency to 0.3, which includes a newer version of num-bigint that compiles with the latest rustc.

This is part of the ongoing ZHF campaign for 24.05.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pluiedev pluiedev added the 0.kind: ZHF Fixes Fixes during the ZHF campaign label May 6, 2024
One of the dependencies of this crate, `num-bigint`, fails to compile on
Rust versions >=1.73 due to a name conflict (see rust-num/num-bigint#219).

This commit fixes the compilation failure by bumping the `gerber-types`
dependency to 0.3, which includes a newer version of `num-bigint` that
compiles with the latest `rustc`.
@wegank wegank merged commit 792e1b4 into NixOS:master May 6, 2024
27 of 28 checks passed
@pluiedev pluiedev deleted the fix/maker-panel branch May 13, 2024 17:26
@pluiedev pluiedev mentioned this pull request May 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants