-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql: 12.18 -> 12.19, 13.14 -> 13.15, 14.11 -> 14.12, 15.6 -> 15.7, 16.2 -> 16.3, fix CVE-2024-4317 for 14+ #310580
Conversation
Note: nominatim is still building, would like to see if it just works with latest postgresql. Otherwise I'd mark it as broken. SGTM. cc @mausch |
…5.7, 16.2 -> 16.3, fix CVE-2024-4317 Announcement: Announcement: https://www.postgresql.org/about/news/postgresql-163-157-1412-1315-and-1219-released-2858/ Backport of NixOS#310580
There is this piece in # TODO: Remove after the next set of minor releases on May 9th 2024
preCheck =
# On musl, comment skip the following tests, because they break due to
# ! ERROR: could not load library "/build/postgresql-11.5/tmp_install/nix/store/...-postgresql-11.5-lib/lib/libpqwalreceiver.so": Error loading shared library libpq.so.5: No such file or directory (needed by /build/postgresql-11.5/tmp_install/nix/store/...-postgresql-11.5-lib/lib/libpqwalreceiver.so)
# See also here:
# https://git.alpinelinux.org/aports/tree/main/postgresql/disable-broken-tests.patch?id=6d7d32c12e073a57a9e5946e55f4c1fbb68bd442
if stdenv'.hostPlatform.isMusl then ''
substituteInPlace src/test/regress/parallel_schedule \
--replace "subscription" "" \
--replace "object_address" ""
'' else null; This can be removed entirely. We better double check whether |
Updated, v12 is part of the PR now. |
The other comment above still applies: #310580 (comment) I added that TODO do remove the test exceptions with the next minor release, so we should do that now. |
Pushed a fix, currently running a pkgsMusl build just to be sure. EDIT: looks good. |
@Ma27 Did you actually push? I can't see the changes in the PR. |
Now I did, apologies! |
This was discussed and agreed on in [1]. [1]: NixOS#310580 (comment)
Description of changes
Announcement: https://www.postgresql.org/about/news/postgresql-163-157-1412-1315-and-1219-released-2858/
cc @wolfgangwalther @ajs124 @mweinelt
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.