-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mackup: init at 0.8.40 #311340
mackup: init at 0.8.40 #311340
Conversation
b771f84
to
6dae298
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3951 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR!
Upstream does have tests, though. Here's how to run them.
And, actually, the failing test just pointed us at a issue we wouldn't have noticed otherwise, hardcoded pgrep
binary: https://github.com/lra/mackup/blob/77e81127c718d12377889aa87b3a1c7501939143/mackup/utils.py#L286.
6dae298
to
52ba93b
Compare
@Misterio77 Updated! Should be resolved now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1648 |
52ba93b
to
b06f432
Compare
b06f432
to
61d1d59
Compare
Description of changes
Mackup is a python application used to keep personal application settings in sync
Requested by GH-309951
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.