mackup: init at 0.8.40 #311340
Merged
mackup: init at 0.8.40 #311340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luftmensch-luftmensch
force-pushed
the
mackup_0.8.40
branch
from
b771f84
to
6dae298
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3951 |
Misterio77
suggested changes
May 17, 2024
There was a problem hiding this comment.
Hey, thanks for the PR!
Upstream does have tests, though. Here's how to run them.
And, actually, the failing test just pointed us at a issue we wouldn't have noticed otherwise, hardcoded pgrep binary: https://github.com/lra/mackup/blob/77e81127c718d12377889aa87b3a1c7501939143/mackup/utils.py#L286.
Misterio77
reviewed
May 17, 2024
luftmensch-luftmensch
force-pushed
the
mackup_0.8.40
branch
from
6dae298
to
52ba93b
Compare
|
@Misterio77 Updated! Should be resolved now |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1648 |
luftmensch-luftmensch
force-pushed
the
mackup_0.8.40
branch
from
52ba93b
to
b06f432
Compare
luftmensch-luftmensch
force-pushed
the
mackup_0.8.40
branch
from
b06f432
to
61d1d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Mackup is a python application used to keep personal application settings in sync
Requested by GH-309951
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.