Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/stalwart-mail: Add test for server version >= 0.7 #313096

Merged
merged 2 commits into from
May 23, 2024

Conversation

onny
Copy link
Contributor

@onny onny commented May 20, 2024

Description of changes

Going to add test for stalwart-mail 0.8 beside already implemented test for stalwart-mail_0_6

Continuation of #304812
Fixes #303156

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@onny
Copy link
Contributor Author

onny commented May 20, 2024

Somehow tests for both versions succeed but stalwart-mail 0.8 throws some errors about configuration syntax

@onny
Copy link
Contributor Author

onny commented May 21, 2024

stalwart-mail 0.8 throws following errors while the test itself succeeds

machine # [    6.527263] stalwart-mail[800]: ERROR: Build error for key "*": Failed to update configuration: Internal Error: Failed to write local configuration file: Read-only file system (os error 30)
machine # [    6.533033] stalwart-mail[800]: ERROR: Build error for key "certificate.snakeoil": No certificates found.

maybe we can ignore the first error because we'll leave the configuration file read-only

@onny onny requested a review from Shawn8901 May 21, 2024 10:31
@onny onny marked this pull request as ready for review May 21, 2024 14:25
@onny
Copy link
Contributor Author

onny commented May 21, 2024

Okay all errors are fixed now :)

Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the remark about the new default for the local public suffixes list, looks good to me 👍

nixos/modules/services/mail/stalwart-mail.nix Show resolved Hide resolved
@pacien
Copy link
Contributor

pacien commented May 21, 2024

I didn't check, but the passthru.tests of the corresponding packages might also need to be updated to reference their respective NixOS tests.

@onny
Copy link
Contributor Author

onny commented May 21, 2024

I didn't check, but the passthru.tests of the corresponding packages might also need to be updated to reference their respective NixOS tests.

The passthru.tests will run always the stalwart-mail test for both packages, hope that's fine :)

@onny onny requested a review from pacien May 21, 2024 19:12
@onny onny added the backport release-24.05 Backport PR automatically label May 23, 2024
@SuperSandro2000 SuperSandro2000 merged commit 360221d into NixOS:master May 23, 2024
23 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stalwart-mail module needs a rewrite for version 0.7.0
4 participants