Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zotero-beta: 7.0.0-65 -> 7.0.0-83 #313107

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

justanotherariel
Copy link
Contributor

@justanotherariel justanotherariel commented May 20, 2024

Description of changes

  • Rename package from zotero_7 to zotero-beta, as zotero_7 will eventually become zotero and beta versions will continue to exist.
  • Created an alias from zotero_7 to zotero-beta to avoid breaking existing configurations relying on the package.
  • Update the beta version to 7.0.0-83.
  • Url is now more generalized (suited for upcoming Zotero beta versions)
  • GPU acceleration is fixed.
  • When first developing this package, I was basing it on the original Zotero package. I wasn't able to make GPU acceleration work with AutoPatchElf Hook.
  • Removed unneeded dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/zo/zotero-beta/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/zo/zotero-beta/package.nix Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/by-name/zo/zotero-beta/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@justanotherariel
Copy link
Contributor Author

justanotherariel commented May 24, 2024

Also closes #306353

@justanotherariel
Copy link
Contributor Author

Update to 7.0.0-83

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4033

@justanotherariel justanotherariel changed the title zotero-beta: 7.0.0-65 -> 7.0.0-79 zotero-beta: 7.0.0-65 -> 7.0.0-83 Jun 4, 2024
@justanotherariel
Copy link
Contributor Author

@SuperSandro2000 Fixed! Question: Is the lib version of a function usually preffered over builtins? If so, why?

@SuperSandro2000
Copy link
Member

I thought I commented something else, too 😅

lib is usually preferred, as it sometimes contains a fallback implementation for old nix versions which is not relevant right now.

@SuperSandro2000 SuperSandro2000 merged commit da1498a into NixOS:master Jun 5, 2024
22 of 24 checks passed
@justanotherariel justanotherariel deleted the zotero-beta branch June 6, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants