Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.myst-parser: 2.0.0 -> 3.0.1 #313349

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

loicreynier
Copy link
Contributor

Description of changes

Update MyST parser to 3.0.1:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but needs to target staging

@loicreynier
Copy link
Contributor Author

Messed around while rebasing into staging but should be good now.

@loicreynier loicreynier marked this pull request as ready for review May 23, 2024 11:46
@loicreynier loicreynier requested a review from nbraud May 23, 2024 11:46
@mweinelt
Copy link
Member

mweinelt commented May 23, 2024

From experience, I'd say we have to run this through python-updates, because lots of fixtures in various packages depend on what myst-parser outputs.

I'll pull it in, when a python-updates run is happening.

@mweinelt mweinelt changed the base branch from staging to python-updates June 19, 2024 02:17
@mweinelt mweinelt merged commit 59ecd22 into NixOS:python-updates Jun 19, 2024
21 of 22 checks passed
Python batch upgrade automation moved this from In progress to Done Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants