Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-completions: add licenses #313769

Merged
merged 3 commits into from
Jun 20, 2024
Merged

zsh-completions: add licenses #313769

merged 3 commits into from
Jun 20, 2024

Conversation

yVieta
Copy link
Contributor

@yVieta yVieta commented May 22, 2024

Description of changes

Reopen Pull request of accidently removed PR of #313477

The main license can be found here: https://github.com/zsh-users/zsh-completions/blob/master/LICENSE
Some Scripts have separated licenses. The licenses were found with https://github.com/nexB/scancode-toolkit.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@yVieta yVieta requested a review from alyssais as a code owner May 22, 2024 19:51
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label May 22, 2024
@@ -1261,11 +1261,21 @@ in mkLicense lset) ({
fullName = "xinetd License";
};

xskat = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split this transposition to its own commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the most efficent way to split it up into an extra commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use git reset HEAD^ or git undo from git-extras

@JohnRTitor JohnRTitor merged commit 1bb6b44 into NixOS:master Jun 20, 2024
26 checks passed
@JohnRTitor
Copy link
Contributor

JohnRTitor commented Jun 20, 2024

We should use the zsh license for zsh package as well according to https://github.com/zsh-users/zsh/blob/master/LICENCE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants