Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-autocomplete: add license #313477

Closed
wants to merge 0 commits into from
Closed

zsh-autocomplete: add license #313477

wants to merge 0 commits into from

Conversation

yVieta
Copy link
Contributor

@yVieta yVieta commented May 21, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yVieta yVieta requested a review from alyssais as a code owner May 21, 2024 20:26
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label May 21, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label May 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 21, 2024
lib/licenses.nix Outdated
zlib = {
spdxId = "Zlib";
fullName = "zlib License";
};

zsh = {
url ="https://github.com/zsh-users/zsh/blob/master/LICENCE";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url ="https://github.com/zsh-users/zsh/blob/master/LICENCE";
url = "https://github.com/zsh-users/zsh/blob/master/LICENCE";

@Shawn8901
Copy link
Contributor

likely you want to rebase your branch, instead of having merges in the PR.

Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a license, but it doesn't add it to any packages like the commit message implies.

@alyssais
Copy link
Member

Should we use this license for the zsh package too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants