Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: make geoip, image filter optional #313844

Merged
merged 3 commits into from
May 27, 2024

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented May 23, 2024

nginx: make geoip, image filter optional

Initial goal was to make libgd optional. Because it reduces nginx package size from 109.88 MiB to 41.99 MiB. (Reduction of -67.88 MiB.) GD is a library for the dynamic creation of images.

With libgd:
nginx-with-libgd

Without libgd:
nginx-without-libgd

Tests runs:

nix build .#nixosTests.{nginx,nginx-auth,nginx-etag,nginx-etag-compression,nginx-globalredirect,nginx-proxyprotocol,nginx-pubhtml,nginx-sso,nginx-status-page,nginx-unix-socket}

CC nginx: @fpletz @RaitoBezarius

@superherointj
Copy link
Contributor Author

@ofborg test nginx nginx-auth nginx-etag nginx-etag-compression nginx-globalredirect nginx-proxyprotocol nginx-pubhtml nginx-sso nginx-status-page nginx-unix-socket

@Izorkin
Copy link
Contributor

Izorkin commented May 23, 2024

Maybe rename it to withImageFilter or withGD?

@superherointj superherointj changed the title nginx: make libgd optional nginx: make image filter optional May 23, 2024
@superherointj superherointj changed the title nginx: make image filter optional nginx: make geoip, image filter optional May 23, 2024
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I totally agree with the change, we have to mention this in the release notes. Some users are probably using one of these extensions.

@superherointj
Copy link
Contributor Author

superherointj commented May 23, 2024

Although I totally agree with the change, we have to mention this in the release notes. Some users are probably using one of these extensions.

By this point. Which release? (rl-2405.section.md or rl-2411.section.md)

Also, these changes are to a package and not a NixOS module.

@fpletz
Copy link
Member

fpletz commented May 23, 2024

Unfortunately, breaking changes are not allowed at this stage of the current release. We should target 24.11.

@superherointj
Copy link
Contributor Author

@fpletz Is the proposed release note acceptable? Thanks for the review.

Reduces nginx package size from 109.88 MiB to 41.99 MiB. Reduction of -67.88 MiB.

GD (libgd.github.io) is a library for the dynamic creation of images.

Co-authored-by: @ulrikstrid
@fpletz fpletz merged commit e047b23 into NixOS:master May 27, 2024
28 checks passed
@superherointj superherointj deleted the nginx-libgd-optional branch May 27, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants