-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx: make geoip, image filter optional #313844
Conversation
@ofborg test nginx nginx-auth nginx-etag nginx-etag-compression nginx-globalredirect nginx-proxyprotocol nginx-pubhtml nginx-sso nginx-status-page nginx-unix-socket |
Maybe rename it to |
09a977a
to
ef3a75e
Compare
6571020
to
4a55d3e
Compare
4a55d3e
to
13478b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I totally agree with the change, we have to mention this in the release notes. Some users are probably using one of these extensions.
By this point. Which release? (rl-2405.section.md or rl-2411.section.md) Also, these changes are to a package and not a NixOS module. |
Unfortunately, breaking changes are not allowed at this stage of the current release. We should target 24.11. |
13478b3
to
60ee650
Compare
@fpletz Is the proposed release note acceptable? Thanks for the review. |
Reduces nginx package size from 109.88 MiB to 41.99 MiB. Reduction of -67.88 MiB. GD (libgd.github.io) is a library for the dynamic creation of images. Co-authored-by: @ulrikstrid
60ee650
to
f2a202f
Compare
nginx: make geoip, image filter optional
Initial goal was to make
libgd
optional. Because it reduces nginx package size from 109.88 MiB to 41.99 MiB. (Reduction of -67.88 MiB.) GD is a library for the dynamic creation of images.With libgd:
Without libgd:
Tests runs:
CC nginx: @fpletz @RaitoBezarius