Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authentik-radius-outpost: init 2024.2.2 #313912

Closed
wants to merge 1 commit into from
Closed

authentik-radius-outpost: init 2024.2.2 #313912

wants to merge 1 commit into from

Conversation

MarcelCoding
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from jvanbruegge May 23, 2024 09:01
jvanbruegge
jvanbruegge suggested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jvanbruegge jvanbruegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message needs to use authentik-outposts.radius so ofborg correctly builds the package

pkgs/by-name/au/authentik/radius.nix Outdated Show resolved Hide resolved
@MarcelCoding MarcelCoding force-pushed the authentik-radius branch 2 times, most recently from 35506b4 to c28da91 Compare May 23, 2024 11:24
@MarcelCoding
Copy link
Member Author

Result of nixpkgs-review pr 313912 run on x86_64-linux 1

1 package built:
  • authentik-outposts.radius

@ofborg ofborg bot requested a review from jvanbruegge May 23, 2024 12:55
@jvanbruegge
Copy link
Contributor

I've also updated authentik now to the latest version here: #313989
If you want to, I can add another commit there to add the radius outpost

@MarcelCoding
Copy link
Member Author

@jvanbruegge sure, feel free to cherry-pick this pr.

@jvanbruegge
Copy link
Contributor

ok, done.

@MarcelCoding MarcelCoding deleted the authentik-radius branch May 24, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jvanbruegge jvanbruegge Awaiting requested review from jvanbruegge

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcelCoding @jvanbruegge @SuperSandro2000