Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ihaskell/wrapper.nix: unify ihaskellEnv and ihaskell #31395

Merged
merged 1 commit into from Nov 27, 2017

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 8, 2017

Motivation for this change

Having both ihaskell and ihaskellEnv is redundant, and might even
cause problems if the two differ somehow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Having both `ihaskell` and `ihaskellEnv` is redundant, and might even
cause problems if the two differ somehow.
@vaibhavsagar
Copy link
Member Author

I've implemented this here with no issues.

@vaibhavsagar
Copy link
Member Author

Are any changes required?

@vaibhavsagar
Copy link
Member Author

Any obstacles to having this merged?

@adisbladis
Copy link
Member

cc @edwtjo (original author) @peti (haskell maintainer)

@peti peti merged commit e7f4979 into NixOS:master Nov 27, 2017
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the cleanup-ihaskell-wrapper branch November 28, 2017 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants