Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.trainer: fix build #314698

Merged
merged 1 commit into from
May 26, 2024
Merged

python3Packages.trainer: fix build #314698

merged 1 commit into from
May 26, 2024

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented May 25, 2024 •
edited
Loading

Description of changes

Fixes build on Python 3.12.

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ConnorBaker ConnorBaker changed the title python3Packages.trainer: fix Python 3.12+ python312Packages.trainer: fix build May 25, 2024
@ofborg ofborg bot requested a review from Mic92 May 25, 2024 23:28
@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 314698 run on x86_64-linux 1

2 packages built:
  • python312Packages.trainer
  • python312Packages.trainer.dist

@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented May 25, 2024 •
edited
Loading

Result of nixpkgs-review pr 314698 run on aarch64-darwin 1

2 packages built:
  • python312Packages.trainer
  • python312Packages.trainer.dist

@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 314698 run on x86_64-darwin 1

2 packages built:
  • python312Packages.trainer
  • python312Packages.trainer.dist

@ConnorBaker
Copy link
Contributor Author

Result of nixpkgs-review pr 314698 run on aarch64-linux 1

2 packages built:
  • python312Packages.trainer
  • python312Packages.trainer.dist

@ConnorBaker ConnorBaker marked this pull request as ready for review May 25, 2024 23:38
@ConnorBaker ConnorBaker self-assigned this May 25, 2024
@ConnorBaker ConnorBaker changed the title python312Packages.trainer: fix build python3Packages.trainer: fix build May 26, 2024
@ConnorBaker ConnorBaker added 0.kind: ZHF Fixes Fixes during the ZHF campaign backport release-24.05 Backport PR automatically labels May 26, 2024
@natsukium
Copy link
Member

@ofborg build python312Packages.trainer

natsukium
natsukium approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit 65aacd0 into NixOS:master May 26, 2024
38 of 40 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 26, 2024
Merged
1 task
@ConnorBaker ConnorBaker deleted the fix/python3Packages.trainer branch May 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

@ConnorBaker ConnorBaker

Labels
0.kind: ZHF Fixes Fixes during the ZHF campaign 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConnorBaker @natsukium